chrome/tab_capture_end2end_tests.isolate - Issue 255403007: Cast: Isolate for tab capture end2end test

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/tab_capture_end2end_tests.isolate

Issue 255403007: Cast: Isolate for tab capture end2end test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Deleted the other file, fixed typos and retested Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # Copyright 2014 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4 {

	5 'includes': [

	6 'browser_tests.isolate',

	7 ],

	8 'conditions': [

	9 ['OS=="linux" or OS=="mac" or OS=="win"', {

	10 'variables': {

	11 'command': [

	12 '../testing/test_env.py',

	13 '<(PRODUCT_DIR)/browser_tests<(EXECUTABLE_SUFFIX)',

	14 '--test-launcher-bot-mode',

	15 '--enable-gpu',

	16 '--test-launcher-jobs=1',

	17 '--gtest_filter=TabCaptureApiPixelTest.EndToEnd*',
	Paweł Hajdan Jr. 2014/05/19 10:23:23 I don't recommend using gtest_filter in this way. I don't recommend using gtest_filter in this way. Depending on what you're trying to do, there should be a better way. Main part of the rationale is that it becomes significantly harder to ensure separate configs (like CQ and main waterfall) are in sync when gtest_filter is present. Ken Russell (switch to Gerrit) 2014/05/19 17:47:21 The intent is to run a small subset of the browser Show quoted text On 2014/05/19 10:23:23, Paweł Hajdan Jr. wrote: > I don't recommend using gtest_filter in this way. Depending on what you're > trying to do, there should be a better way. > > Main part of the rationale is that it becomes significantly harder to ensure > separate configs (like CQ and main waterfall) are in sync when gtest_filter is > present. The intent is to run a small subset of the browser_tests. Can you suggest another way? Note I specifically do not want to put the gtest_filter in the GPU recipe. We've run into multiple problems trying to make changes to tests' configurations when some of the configuration is in the recipe and the rest is in the Chromium workspace. The configuration of these tests should be entirely in the Chromium workspace and thus in the isolate.
	18 ],

	19 'isolate_dependency_untracked': [

	20 'test/data/extensions/api_test/tab_capture/',

	21 ],

	22 },

	23 }],

	24 ],

	25 }

OLD	NEW

« no previous file with comments | « chrome/chrome_tests.gypi ('k') | no next file » | no next file with comments »