[MediaNotification] Unset previous custom large icon correctly

[MediaNotification] Unset previous custom large icon correctly

In this CL, the custom large icon in media notification is unset (falling back
to favicon or default icon) in the following conditions:

* The newly-set MediaMetadata has no valid MediaImage,
* Downloading MediaImage failed.

Test page:
http://xxyzzzq.github.io/sandbox/media-session/full-test-artwork.html

BUG=672015
Test=Manual

Committed: https://crrev.com/5921862bd10d297e759a5ebf28bb90aba5b87650
Cr-Commit-Position: refs/heads/master@{#437084}

[Zhiqiang Zhang (Slow), 2016-12-07 13:49:33]

zqzhang@chromium.org changed reviewers:
+ avayvod@chromium.org

[whywhat, 2016-12-07 20:24:14]

lgtm

https://codereview.chromium.org/2554013004/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaImageManager.java
(right):

https://codereview.chromium.org/2554013004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaImageManager.java:128:
mCallback.onImageDownloaded(null);
nit: could you mark the arguments to the callback and other calls where this
null will be passed around (e.g. scale...Image in MediaNotificationManager) as
@Nullable and add comments that null can be accepted or can be returned.

[Zhiqiang Zhang (Slow), 2016-12-07 21:20:01]

https://codereview.chromium.org/2554013004/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaImageManager.java
(right):

https://codereview.chromium.org/2554013004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaImageManager.java:128:
mCallback.onImageDownloaded(null);
On 2016/12/07 20:24:14, whywhat wrote:
> nit: could you mark the arguments to the callback and other calls where this
> null will be passed around (e.g. scale...Image in MediaNotificationManager) as
> @Nullable and add comments that null can be accepted or can be returned.

Done.

[Zhiqiang Zhang (Slow), 2016-12-07 21:20:06]

The CQ bit was checked by zqzhang@chromium.org

[Zhiqiang Zhang (Slow), 2016-12-07 21:20:07]

The patchset sent to the CQ was uploaded after l-g-t-m from avayvod@chromium.org
Link to the patchset: https://codereview.chromium.org/2554013004/#ps20001
(title: "nits")

[commit-bot: I haz the power, 2016-12-07 21:20:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 22:18:59]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481145606378570,
"parent_rev": "2e9a891869d7079ba3e6eaea4e7b1637e31b866e", "commit_rev":
"fc34e5d42ad6ac9f6ad0ab2fde2f2bec2d082399"}

[commit-bot: I haz the power, 2016-12-07 22:19:27]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-07 22:22:14]

Description was changed from

==========
[MediaNotification] Unset previous custom large icon correctly

In this CL, the custom large icon in media notification is unset (falling back
to favicon or default icon) in the following conditions:

* The newly-set MediaMetadata has no valid MediaImage,
* Downloading MediaImage failed.

Test page:
http://xxyzzzq.github.io/sandbox/media-session/full-test-artwork.html

BUG=672015
Test=Manual
==========

to

==========
[MediaNotification] Unset previous custom large icon correctly

In this CL, the custom large icon in media notification is unset (falling back
to favicon or default icon) in the following conditions:

* The newly-set MediaMetadata has no valid MediaImage,
* Downloading MediaImage failed.

Test page:
http://xxyzzzq.github.io/sandbox/media-session/full-test-artwork.html

BUG=672015
Test=Manual

Committed: https://crrev.com/5921862bd10d297e759a5ebf28bb90aba5b87650
Cr-Commit-Position: refs/heads/master@{#437084}
==========

[commit-bot: I haz the power, 2016-12-07 22:22:15]

Patchset 2 (id:??) landed as
https://crrev.com/5921862bd10d297e759a5ebf28bb90aba5b87650
Cr-Commit-Position: refs/heads/master@{#437084}