chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaImageManager.java - Issue 2554013004: [MediaNotification] Unset previous custom large icon correctly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaImageManager.java

Issue 2554013004: [MediaNotification] Unset previous custom large icon correctly (Closed)

Patch Set: nits Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaImageCallback.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaImageManager.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaImageManager.java b/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaImageManager.java

index 768502b01828672993af8988a9b04b997a79d8b8..0010848686f0eb022463f97010b3403b3726c2af 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaImageManager.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaImageManager.java

@@ -124,7 +124,11 @@ public class MediaImageManager implements ImageDownloadCallback {

mCallback = callback;

MediaImage image = selectImage(images);

- if (image == null) return;

+ if (image == null) {

+ mCallback.onImageDownloaded(null);

+ clearRequests();

+ return;

+ }

mRequestId = mWebContents.downloadImage(

image.getSrc(), false, 8 * mIdealSize, false, this);

@@ -163,7 +167,7 @@ public class MediaImageManager implements ImageDownloadCallback {

bestScore = newScore;

}

- if (bestBitmap != null) mCallback.onImageDownloaded(bestBitmap);

+ mCallback.onImageDownloaded(bestBitmap);

clearRequests();

}