Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2553993002:
binding: Re-enables blink_perf.bindings on all platforms. (Closed)
Descriptionbinding: Re-enables blink_perf.bindings on all platforms.
serialize-nested-array.html in blink_perf.bindings was failing
because of too much of nest level in test code, which was
causing stack overflow in V8. The failure was triggered with
https://crrev.com/2517813002 .
Discussed with the test owner peria@ and reached to a conclusion
that we don't need such a huge nest level for this test. Thus,
this CL reduces the nest level of the test.
BUG=670069
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
Committed: https://crrev.com/c344e57998af6ad9ec3778ae510bf3ce635d1614
Cr-Commit-Position: refs/heads/master@{#439859}
Patch Set 1 #Patch Set 2 : Synched. #Patch Set 3 : Reduced the nest level according to https://crrev.com/2517813002 #
Messages
Total messages: 28 (22 generated)
Description was changed from ========== binding: Re-enables blink_perf.bindings on all platforms. BUG= ========== to ========== binding: Re-enables blink_perf.bindings on all platforms. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
Description was changed from ========== binding: Re-enables blink_perf.bindings on all platforms. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== binding: Re-enables blink_perf.bindings on all platforms. BUG=670069 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
The CQ bit was checked by yukishiino@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_perf_cq on master.tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/linux_perf_cq/bu...)
Description was changed from ========== binding: Re-enables blink_perf.bindings on all platforms. BUG=670069 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== binding: Re-enables blink_perf.bindings on all platforms. The tests were disabled with https://crrev.com/2543783002 , but it seems no longer having an issue (was an infra issue or something?). Thus, enables the tests again. BUG=670069 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
The CQ bit was checked by yukishiino@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_perf_cq on master.tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/linux_perf_cq/bu...)
The CQ bit was checked by yukishiino@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== binding: Re-enables blink_perf.bindings on all platforms. The tests were disabled with https://crrev.com/2543783002 , but it seems no longer having an issue (was an infra issue or something?). Thus, enables the tests again. BUG=670069 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== binding: Re-enables blink_perf.bindings on all platforms. serialize-nested-array.html in blink_perf.bindings was failing because of too much of nest level in test code, which was causing stack overflow in V8. Discussed with the test owner peria@ and reached to a conclusion that we don't need such huge nest level for this test. Thus, this CL reduces the nest level of the test. BUG=670069 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
Description was changed from ========== binding: Re-enables blink_perf.bindings on all platforms. serialize-nested-array.html in blink_perf.bindings was failing because of too much of nest level in test code, which was causing stack overflow in V8. Discussed with the test owner peria@ and reached to a conclusion that we don't need such huge nest level for this test. Thus, this CL reduces the nest level of the test. BUG=670069 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== binding: Re-enables blink_perf.bindings on all platforms. serialize-nested-array.html in blink_perf.bindings was failing because of too much of nest level in test code, which was causing stack overflow in V8. The failure was triggered with https://crrev.com/2517813002 . Discussed with the test owner peria@ and reached to a conclusion that we don't need such a huge nest level for this test. Thus, this CL reduces the nest level of the test. BUG=670069 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
yukishiino@chromium.org changed reviewers: + peria@chromium.org, sullivan@chromium.org
Could you guys review this CL?
LGTM This test is just to avoid *large* regressions, so it is acceptable to reduce the size while we can measure time.
The CQ bit was checked by sullivan@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1482260215953970,
"parent_rev": "cb3a6644087e26abfef4476db90f5b3e764b3f71", "commit_rev":
"52b0d0c8795ed2503ac13dbdafd94b8aab8fb603"}
Message was sent while issue was closed.
Description was changed from ========== binding: Re-enables blink_perf.bindings on all platforms. serialize-nested-array.html in blink_perf.bindings was failing because of too much of nest level in test code, which was causing stack overflow in V8. The failure was triggered with https://crrev.com/2517813002 . Discussed with the test owner peria@ and reached to a conclusion that we don't need such a huge nest level for this test. Thus, this CL reduces the nest level of the test. BUG=670069 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== binding: Re-enables blink_perf.bindings on all platforms. serialize-nested-array.html in blink_perf.bindings was failing because of too much of nest level in test code, which was causing stack overflow in V8. The failure was triggered with https://crrev.com/2517813002 . Discussed with the test owner peria@ and reached to a conclusion that we don't need such a huge nest level for this test. Thus, this CL reduces the nest level of the test. BUG=670069 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq Review-Url: https://codereview.chromium.org/2553993002 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== binding: Re-enables blink_perf.bindings on all platforms. serialize-nested-array.html in blink_perf.bindings was failing because of too much of nest level in test code, which was causing stack overflow in V8. The failure was triggered with https://crrev.com/2517813002 . Discussed with the test owner peria@ and reached to a conclusion that we don't need such a huge nest level for this test. Thus, this CL reduces the nest level of the test. BUG=670069 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq Review-Url: https://codereview.chromium.org/2553993002 ========== to ========== binding: Re-enables blink_perf.bindings on all platforms. serialize-nested-array.html in blink_perf.bindings was failing because of too much of nest level in test code, which was causing stack overflow in V8. The failure was triggered with https://crrev.com/2517813002 . Discussed with the test owner peria@ and reached to a conclusion that we don't need such a huge nest level for this test. Thus, this CL reduces the nest level of the test. BUG=670069 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq Committed: https://crrev.com/c344e57998af6ad9ec3778ae510bf3ce635d1614 Cr-Commit-Position: refs/heads/master@{#439859} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/c344e57998af6ad9ec3778ae510bf3ce635d1614 Cr-Commit-Position: refs/heads/master@{#439859} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
