Establish a list marker's offset before floats have been added to its line

Establish a list marker's offset before floats have been added to its line

Computing the offset for a list marker after the rest of the objects on the line
it is on have been laid out means it will avoid floats it ought not to.

Instead, compute the offset when laying out the marker and cache it for use later.

BUG=548616
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/c896e79e5ba348d7ed87438cd3a19d0176f3036d
Cr-Commit-Position: refs/heads/master@{#437798}

[rhogan, 2016-12-05 22:22:48]

The CQ bit was checked by robhogan@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-05 22:23:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 23:54:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-05 23:54:35]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[rhogan, 2016-12-06 22:11:43]

The CQ bit was checked by robhogan@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 22:12:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 00:22:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 00:22:10]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[rhogan, 2016-12-07 20:17:18]

Description was changed from

==========
bug 548616

BUG=548616
==========

to

==========
Establish a list marker's offset before floats have been added to its line

Computing the offset for a list marker after the rest of the objects on the line
it is on has been laid out means it will avoid floats it ought not to.

Instead, compute the offset when laying out the marker and cache it for use
later.

BUG=548616
==========

[rhogan, 2016-12-07 20:17:19]

robhogan@gmail.com changed reviewers:
+ eae@chromium.org

[eae, 2016-12-07 21:30:45]

LGTM w/suggestion

https://codereview.chromium.org/2553793003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutListMarker.cpp (right):

https://codereview.chromium.org/2553793003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutListMarker.cpp:143: for (LayoutBox*
o = parentBox(); o != listItem(); o = o->parentBox()) {
Is parentBox guaranteed to be non-null? If not we might want to change the
condition to:

o && o != listItem()

[rhogan, 2016-12-10 11:52:39]

The CQ bit was checked by robhogan@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-10 11:52:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rhogan, 2016-12-10 13:07:53]

Description was changed from

==========
Establish a list marker's offset before floats have been added to its line

Computing the offset for a list marker after the rest of the objects on the line
it is on has been laid out means it will avoid floats it ought not to.

Instead, compute the offset when laying out the marker and cache it for use
later.

BUG=548616
==========

to

==========
Establish a list marker's offset before floats have been added to its line

Computing the offset for a list marker after the rest of the objects on the line
it is on have been laid out means it will avoid floats it ought not to.

Instead, compute the offset when laying out the marker and cache it for use
later.

BUG=548616
==========

[commit-bot: I haz the power, 2016-12-10 13:18:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-10 13:18:27]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[rhogan, 2016-12-10 14:21:15]

The CQ bit was checked by robhogan@gmail.com

[rhogan, 2016-12-10 14:21:16]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2553793003/#ps40001
(title: "bug 548616")

[commit-bot: I haz the power, 2016-12-10 14:21:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-10 15:56:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-10 15:56:55]

Failed to apply patch for third_party/WebKit/LayoutTests/TestExpectations:
While running git apply --index -p1;
  error: patch failed: third_party/WebKit/LayoutTests/TestExpectations:636
  error: third_party/WebKit/LayoutTests/TestExpectations: patch does not apply

Patch:       third_party/WebKit/LayoutTests/TestExpectations
Index: third_party/WebKit/LayoutTests/TestExpectations
diff --git a/third_party/WebKit/LayoutTests/TestExpectations
b/third_party/WebKit/LayoutTests/TestExpectations
index
e5daf25c84043b8282f4e8c80bbcf40624ccc467..08c2d3242021362cc6efa42b47f18e7abbeb9eb7
100644
--- a/third_party/WebKit/LayoutTests/TestExpectations
+++ b/third_party/WebKit/LayoutTests/TestExpectations
@@ -636,6 +636,11 @@ crbug.com/552494
virtual/rootlayerscrolls/scrollbars/overflow-scrollbar-combinat
 crbug.com/659456 http/tests/inspector/persistence/automapping-sourcemap.html [
Pass Failure ]
 crbug.com/659456
virtual/mojo-loading/http/tests/inspector/persistence/automapping-sourcemap.html
[ Pass Failure ]
 
+crbug.com/548616 [ Mac Win ]
fast/lists/list-marker-before-float-nested-rtl.html [ NeedsRebaseline ]
+crbug.com/548616 [ Mac Win ] fast/lists/list-marker-before-float-nested.html [
NeedsRebaseline ]
+crbug.com/548616 [ Mac Win ] fast/lists/list-marker-before-float-rtl.html [
NeedsRebaseline ]
+crbug.com/548616 [ Mac Win ] fast/lists/list-marker-before-float.html [
NeedsRebaseline ]
+
 crbug.com/605840 [ Linux Win ]
fast/text/hyphens/hyphen-min-preferred-width-mock.html [ Skip ]
 crbug.com/605840 [ Linux Win ] fast/text/hyphens/hyphens-auto.html [ Skip ]
 crbug.com/605840 [ Linux Win ] fast/text/hyphens/hyphens-auto-mock.html [ Skip
]

[rhogan, 2016-12-11 17:23:36]

Description was changed from

==========
Establish a list marker's offset before floats have been added to its line

Computing the offset for a list marker after the rest of the objects on the line
it is on have been laid out means it will avoid floats it ought not to.

Instead, compute the offset when laying out the marker and cache it for use
later.

BUG=548616
==========

to

==========
Establish a list marker's offset before floats have been added to its line

Computing the offset for a list marker after the rest of the objects on the line
it is on have been laid out means it will avoid floats it ought not to.

Instead, compute the offset when laying out the marker and cache it for use
later.

BUG=548616
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[rhogan, 2016-12-11 17:23:44]

The CQ bit was checked by robhogan@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-11 17:23:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rhogan, 2016-12-11 17:25:12]

The CQ bit was unchecked by robhogan@gmail.com

[rhogan, 2016-12-11 17:26:20]

The CQ bit was checked by robhogan@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-11 17:26:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rhogan, 2016-12-11 17:26:39]

The CQ bit was unchecked by robhogan@gmail.com

[rhogan, 2016-12-11 17:26:42]

The CQ bit was checked by robhogan@gmail.com

[rhogan, 2016-12-11 17:26:43]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2553793003/#ps80001
(title: "bug 548616")

[commit-bot: I haz the power, 2016-12-11 17:26:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-11 19:04:17]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1481477202569820,
"parent_rev": "ea7f6b80fc32437cccc177c7ff5186d6a53d938f", "commit_rev":
"1267b55829a7027853664b2258c5e7056e564141"}

[commit-bot: I haz the power, 2016-12-11 19:04:43]

Description was changed from

==========
Establish a list marker's offset before floats have been added to its line

Computing the offset for a list marker after the rest of the objects on the line
it is on have been laid out means it will avoid floats it ought not to.

Instead, compute the offset when laying out the marker and cache it for use
later.

BUG=548616
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Establish a list marker's offset before floats have been added to its line

Computing the offset for a list marker after the rest of the objects on the line
it is on have been laid out means it will avoid floats it ought not to.

Instead, compute the offset when laying out the marker and cache it for use
later.

BUG=548616
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2553793003
==========

[commit-bot: I haz the power, 2016-12-11 19:04:45]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-12-12 15:09:55]

Description was changed from

==========
Establish a list marker's offset before floats have been added to its line

Computing the offset for a list marker after the rest of the objects on the line
it is on have been laid out means it will avoid floats it ought not to.

Instead, compute the offset when laying out the marker and cache it for use
later.

BUG=548616
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2553793003
==========

to

==========
Establish a list marker's offset before floats have been added to its line

Computing the offset for a list marker after the rest of the objects on the line
it is on have been laid out means it will avoid floats it ought not to.

Instead, compute the offset when laying out the marker and cache it for use
later.

BUG=548616
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/c896e79e5ba348d7ed87438cd3a19d0176f3036d
Cr-Commit-Position: refs/heads/master@{#437798}
==========

[commit-bot: I haz the power, 2016-12-12 15:09:55]

Patchset 5 (id:??) landed as
https://crrev.com/c896e79e5ba348d7ed87438cd3a19d0176f3036d
Cr-Commit-Position: refs/heads/master@{#437798}