Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2553753002: Prevent repeated VRDisplay.requestPresent calls from spamming the device (Closed)

Created:
4 years ago by bajones
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Prevent repeated VRDisplay.requestPresent calls from spamming the device With this patch new requestPresent calls that are made while the first one is still pending will simply be queued up Blink-side and all resolved at once when the original request succeeds or fails. BUG=670441 Review-Url: https://codereview.chromium.org/2550863002 Cr-Commit-Position: refs/heads/master@{#436132} (cherry picked from commit dd2fff71ca63ff58973e36c6f411a78f04bcc7fb) Committed: https://chromium.googlesource.com/chromium/src/+/c634718cdaed84e3f68f324f72908be66a2310e3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -14 lines) Patch
M third_party/WebKit/Source/modules/vr/VRDisplay.h View 3 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/VRDisplay.cpp View 7 chunks +28 lines, -12 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
bajones
4 years ago (2016-12-05 17:44:02 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c634718cdaed84e3f68f324f72908be66a2310e3.

Powered by Google App Engine
This is Rietveld 408576698