Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2550863002: Prevent repeated VRDisplay.requestPresent calls from spamming the device (Closed)

Created:
4 years ago by bajones
Modified:
4 years ago
Reviewers:
klausw
CC:
chromium-reviews, blink-reviews, haraken, feature-vr-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prevent repeated VRDisplay.requestPresent calls from spamming the device With this patch new requestPresent calls that are made while the first one is still pending will simply be queued up Blink-side and all resolved at once when the original request succeeds or fails. BUG=670441 Committed: https://crrev.com/dd2fff71ca63ff58973e36c6f411a78f04bcc7fb Cr-Commit-Position: refs/heads/master@{#436132}

Patch Set 1 #

Patch Set 2 : Minor cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -14 lines) Patch
M third_party/WebKit/Source/modules/vr/VRDisplay.h View 3 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/VRDisplay.cpp View 1 7 chunks +28 lines, -12 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
bajones
PTAL. Fixes the issue with multiple requestPresent calls in quick succession causing us to get ...
4 years ago (2016-12-02 23:29:33 UTC) #2
klausw
LGTM!
4 years ago (2016-12-02 23:33:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2550863002/20001
4 years ago (2016-12-02 23:41:44 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-03 01:37:35 UTC) #7
commit-bot: I haz the power
4 years ago (2016-12-03 01:39:48 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dd2fff71ca63ff58973e36c6f411a78f04bcc7fb
Cr-Commit-Position: refs/heads/master@{#436132}

Powered by Google App Engine
This is Rietveld 408576698