Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(775)

Issue 2553683006: Add HpackDecoder2. (Closed)

Created:
4 years ago by Bence
Modified:
4 years ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add HpackDecoder2. Add HpackDecoder2, which uses the HPACK decoder implementation in //net/http2/. Also parametrize SpdyFramerTests to exercise HpackDecoder2. This CL lands server side changes 126903124, 127080051, 129035800, 129262200, and 129452354 by jamessynge. BUG=488484 Committed: https://crrev.com/4bef29789b3d3677015214a8b4f769b305361b40 Cr-Commit-Position: refs/heads/master@{#436693}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1582 lines, -107 lines) Patch
M net/net.gypi View 2 chunks +3 lines, -0 lines 0 comments Download
A net/spdy/hpack/hpack_decoder2.h View 1 chunk +146 lines, -0 lines 0 comments Download
A net/spdy/hpack/hpack_decoder2.cc View 1 chunk +330 lines, -0 lines 0 comments Download
A net/spdy/hpack/hpack_decoder2_test.cc View 1 chunk +954 lines, -0 lines 0 comments Download
M net/spdy/spdy_flags.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/spdy/spdy_flags.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M net/spdy/spdy_framer.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/spdy/spdy_framer.cc View 2 chunks +7 lines, -1 line 0 comments Download
M net/spdy/spdy_framer_test.cc View 107 chunks +137 lines, -105 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Bence
Ryan: PTAL.
4 years ago (2016-12-06 19:21:21 UTC) #6
Ryan Hamilton
lgtm
4 years ago (2016-12-06 19:59:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2553683006/1
4 years ago (2016-12-06 20:00:54 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-06 20:27:59 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-06 20:32:21 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4bef29789b3d3677015214a8b4f769b305361b40
Cr-Commit-Position: refs/heads/master@{#436693}

Powered by Google App Engine
This is Rietveld 408576698