Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1334)

Issue 2553663002: [NTP] Do not force offline version when opening non-download snippets. (Closed)

Created:
4 years ago by Marc Treib
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

[NTP] Do not force offline version when opening non-download snippets. Previously we always opened an offline page, if there was one. This CL simply opens the URL for non-download snippets and then Offline Pages decide whether to open its offline page. For Downloads nothing changed. BUG=668485 Review-Url: https://codereview.chromium.org/2525323003 Cr-Commit-Position: refs/heads/master@{#434445} (cherry picked from commit 6f538029f3659bf667470deca0b22abdcd7cafbd) Committed: https://chromium.googlesource.com/chromium/src/+/5d36250aae160e1a5f37b80638bd5ef588bde6e1

Patch Set 1 #

Patch Set 2 : merge fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java View 1 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Marc Treib
4 years ago (2016-12-05 15:05:20 UTC) #2
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
5d36250aae160e1a5f37b80638bd5ef588bde6e1.

Powered by Google App Engine
This is Rietveld 408576698