|
|
Chromium Code Reviews
DescriptionUpdate thumbnail md5s for new Mali drop
test-fps25.h264 and vp8 thumbnail md5s were different than ARM-Exynos
from 9033.0.0 due to new Mali drop. Updated md5s for those.
Also update vp9 md5 for RK3399.
BUG=670160
TEST=test on Minnie and Kevin for
Thumbnail/VideoDecodeAcceleratorParamTest.TestSimpleDecode/0
Committed: https://crrev.com/44e989098aaaddeb9f0ee857282bc8cdaa1cc3d1
Cr-Commit-Position: refs/heads/master@{#437835}
Patch Set 1 #
Total comments: 5
Patch Set 2 : Update thumbnail md5s for ARM-Mali #
Total comments: 3
Patch Set 3 : Update thumbnail md5s for new Mali drop #
Messages
Total messages: 29 (11 generated)
johnylin@chromium.org changed reviewers: + posciak@chromium.org, wuchengli@chromium.org, xhwang@chromium.org
I am not familiar with this. But, if we don't land this CL, will there be any test failing to catch this?
https://codereview.chromium.org/2553653002/diff/1/media/test/data/test-25fps.... File media/test/data/test-25fps.h264.md5 (right): https://codereview.chromium.org/2553653002/diff/1/media/test/data/test-25fps.... media/test/data/test-25fps.h264.md5:13: # ARM - Exynos Perhaps we should s/Exynos/Mali/
https://codereview.chromium.org/2553653002/diff/1/media/test/data/test-25fps.... File media/test/data/test-25fps.h264.md5 (right): https://codereview.chromium.org/2553653002/diff/1/media/test/data/test-25fps.... media/test/data/test-25fps.h264.md5:14: 82c979d493a00ee2188f7259230a8de9 Do we need to make a similar change for all *.md5 files, not only h264 one?
Description was changed from
==========
Update h264 thumbnail md5 for ARM-Exynos
h264 thumbnail md5 has changed from 9033.0.0 due to new mali drop. Verified new
thumbnails are still good and updated new md5 value.
BUG=670160
TEST=test on Minnie and Kevin for
Thumbnail/VideoDecodeAcceleratorParamTest.TestSimpleDecode/0
==========
to
==========
Update thumbnail md5s for ARM-Mali
test-fps25.h264 and vp8 thumbnail md5s were different than ARM-Exynos
from 9033.0.0 due to new Mali drop. Updated md5s for Mali.
BUG=670160
TEST=test on Minnie and Kevin for
Thumbnail/VideoDecodeAcceleratorParamTest.TestSimpleDecode/0
==========
https://codereview.chromium.org/2553653002/diff/1/media/test/data/test-25fps.... File media/test/data/test-25fps.h264.md5 (right): https://codereview.chromium.org/2553653002/diff/1/media/test/data/test-25fps.... media/test/data/test-25fps.h264.md5:14: 82c979d493a00ee2188f7259230a8de9 On 2016/12/06 07:41:40, Pawel Osciak wrote: > Do we need to make a similar change for all *.md5 files, not only h264 one? I saw there are also bear.h264.md5, red-green.h264.md5, npot-video.h264.md5 but they are kind of outdated (only have a few md5 values inside). Are we still using them? https://codereview.chromium.org/2553653002/diff/20001/media/test/data/test-25... File media/test/data/test-25fps.h264.md5 (right): https://codereview.chromium.org/2553653002/diff/20001/media/test/data/test-25... media/test/data/test-25fps.h264.md5:15: # ARM - Mali I reserve the md5 value of ARM-Exynos and add ARM-Mali as a new one. But I'm not sure if ARM-Mali is a good name since "Exynos" is SOC name and "Mali" is the name of GPU.
https://codereview.chromium.org/2553653002/diff/1/media/test/data/test-25fps.... File media/test/data/test-25fps.h264.md5 (right): https://codereview.chromium.org/2553653002/diff/1/media/test/data/test-25fps.... media/test/data/test-25fps.h264.md5:14: 82c979d493a00ee2188f7259230a8de9 On 2016/12/07 07:24:54, johnylin1 wrote: > On 2016/12/06 07:41:40, Pawel Osciak wrote: > > Do we need to make a similar change for all *.md5 files, not only h264 one? > > I saw there are also bear.h264.md5, red-green.h264.md5, npot-video.h264.md5 but > they are kind of outdated (only have a few md5 values inside). Are we still > using them? Not in our tests. I only meant test-25fps.vp8.md5 and test-25fps.vp9.md5. https://codereview.chromium.org/2553653002/diff/20001/media/test/data/test-25... File media/test/data/test-25fps.h264.md5 (right): https://codereview.chromium.org/2553653002/diff/20001/media/test/data/test-25... media/test/data/test-25fps.h264.md5:15: # ARM - Mali On 2016/12/07 07:24:54, johnylin1 wrote: > I reserve the md5 value of ARM-Exynos and add ARM-Mali as a new one. > I would prefer to remove old md5 that are no longer in use. > But I'm not sure if ARM-Mali is a good name since "Exynos" is SOC name and > "Mali" is the name of GPU. Yes, but we have multiple SoCs using Mali and they match the same MD5.
Description was changed from
==========
Update thumbnail md5s for ARM-Mali
test-fps25.h264 and vp8 thumbnail md5s were different than ARM-Exynos
from 9033.0.0 due to new Mali drop. Updated md5s for Mali.
BUG=670160
TEST=test on Minnie and Kevin for
Thumbnail/VideoDecodeAcceleratorParamTest.TestSimpleDecode/0
==========
to
==========
Update thumbnail md5s for new Mali drop
test-fps25.h264 and vp8 thumbnail md5s were different than ARM-Exynos
from 9033.0.0 due to new Mali drop. Updated md5s for those.
Also update vp9 md5 for RK3399.
BUG=670160
TEST=test on Minnie and Kevin for
Thumbnail/VideoDecodeAcceleratorParamTest.TestSimpleDecode/0
==========
On 2016/12/05 17:43:57, xhwang wrote: > I am not familiar with this. But, if we don't land this CL, will there be any > test failing to catch this? Yes, Thumbnail/VideoDecodeAcceleratorParamTest.TestSimpleDecode/0 will fail. The md5sum is changed due to a new Mali drop so every chipset using this GPU will be affected.
https://codereview.chromium.org/2553653002/diff/1/media/test/data/test-25fps.... File media/test/data/test-25fps.h264.md5 (right): https://codereview.chromium.org/2553653002/diff/1/media/test/data/test-25fps.... media/test/data/test-25fps.h264.md5:14: 82c979d493a00ee2188f7259230a8de9 On 2016/12/07 07:36:39, Pawel Osciak wrote: > On 2016/12/07 07:24:54, johnylin1 wrote: > > On 2016/12/06 07:41:40, Pawel Osciak wrote: > > > Do we need to make a similar change for all *.md5 files, not only h264 one? > > > > I saw there are also bear.h264.md5, red-green.h264.md5, npot-video.h264.md5 > but > > they are kind of outdated (only have a few md5 values inside). Are we still > > using them? > > Not in our tests. > I only meant test-25fps.vp8.md5 and test-25fps.vp9.md5. Done. https://codereview.chromium.org/2553653002/diff/20001/media/test/data/test-25... File media/test/data/test-25fps.h264.md5 (right): https://codereview.chromium.org/2553653002/diff/20001/media/test/data/test-25... media/test/data/test-25fps.h264.md5:15: # ARM - Mali On 2016/12/07 07:36:39, Pawel Osciak wrote: > On 2016/12/07 07:24:54, johnylin1 wrote: > > I reserve the md5 value of ARM-Exynos and add ARM-Mali as a new one. > > > > I would prefer to remove old md5 that are no longer in use. > > > But I'm not sure if ARM-Mali is a good name since "Exynos" is SOC name and > > "Mali" is the name of GPU. > > Yes, but we have multiple SoCs using Mali and they match the same MD5. Done.
lgtm
On 2016/12/07 08:48:02, johnylin1 wrote: > On 2016/12/05 17:43:57, xhwang wrote: > > I am not familiar with this. But, if we don't land this CL, will there be any > > test failing to catch this? > > Yes, Thumbnail/VideoDecodeAcceleratorParamTest.TestSimpleDecode/0 will fail. The FYI, it's in chrome video_decode_accelerator_unittest > md5sum is changed due to a new Mali drop so every chipset using this GPU will be > affected.
thanks rs lgtm
The CQ bit was checked by johnylin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by johnylin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by wuchengli@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481527826862220,
"parent_rev": "75ed701936abca36c0be6cf7e0444db208c68298", "commit_rev":
"ecee37c7525c23e085694f70589f170cb15e1e9f"}
Message was sent while issue was closed.
Description was changed from
==========
Update thumbnail md5s for new Mali drop
test-fps25.h264 and vp8 thumbnail md5s were different than ARM-Exynos
from 9033.0.0 due to new Mali drop. Updated md5s for those.
Also update vp9 md5 for RK3399.
BUG=670160
TEST=test on Minnie and Kevin for
Thumbnail/VideoDecodeAcceleratorParamTest.TestSimpleDecode/0
==========
to
==========
Update thumbnail md5s for new Mali drop
test-fps25.h264 and vp8 thumbnail md5s were different than ARM-Exynos
from 9033.0.0 due to new Mali drop. Updated md5s for those.
Also update vp9 md5 for RK3399.
BUG=670160
TEST=test on Minnie and Kevin for
Thumbnail/VideoDecodeAcceleratorParamTest.TestSimpleDecode/0
Review-Url: https://codereview.chromium.org/2553653002
==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from
==========
Update thumbnail md5s for new Mali drop
test-fps25.h264 and vp8 thumbnail md5s were different than ARM-Exynos
from 9033.0.0 due to new Mali drop. Updated md5s for those.
Also update vp9 md5 for RK3399.
BUG=670160
TEST=test on Minnie and Kevin for
Thumbnail/VideoDecodeAcceleratorParamTest.TestSimpleDecode/0
Review-Url: https://codereview.chromium.org/2553653002
==========
to
==========
Update thumbnail md5s for new Mali drop
test-fps25.h264 and vp8 thumbnail md5s were different than ARM-Exynos
from 9033.0.0 due to new Mali drop. Updated md5s for those.
Also update vp9 md5 for RK3399.
BUG=670160
TEST=test on Minnie and Kevin for
Thumbnail/VideoDecodeAcceleratorParamTest.TestSimpleDecode/0
Committed: https://crrev.com/44e989098aaaddeb9f0ee857282bc8cdaa1cc3d1
Cr-Commit-Position: refs/heads/master@{#437835}
==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/44e989098aaaddeb9f0ee857282bc8cdaa1cc3d1 Cr-Commit-Position: refs/heads/master@{#437835} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
