Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2553653002: Update thumbnail md5s for new Mali drop (Closed)

Created:
4 years ago by johnylin1
Modified:
4 years ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update thumbnail md5s for new Mali drop test-fps25.h264 and vp8 thumbnail md5s were different than ARM-Exynos from 9033.0.0 due to new Mali drop. Updated md5s for those. Also update vp9 md5 for RK3399. BUG=670160 TEST=test on Minnie and Kevin for Thumbnail/VideoDecodeAcceleratorParamTest.TestSimpleDecode/0 Committed: https://crrev.com/44e989098aaaddeb9f0ee857282bc8cdaa1cc3d1 Cr-Commit-Position: refs/heads/master@{#437835}

Patch Set 1 #

Total comments: 5

Patch Set 2 : Update thumbnail md5s for ARM-Mali #

Total comments: 3

Patch Set 3 : Update thumbnail md5s for new Mali drop #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M media/test/data/test-25fps.h264.md5 View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M media/test/data/test-25fps.vp8.md5 View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M media/test/data/test-25fps.vp9.md5 View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 29 (11 generated)
johnylin1
4 years ago (2016-12-05 14:17:07 UTC) #2
xhwang
I am not familiar with this. But, if we don't land this CL, will there ...
4 years ago (2016-12-05 17:43:57 UTC) #3
Pawel Osciak
https://codereview.chromium.org/2553653002/diff/1/media/test/data/test-25fps.h264.md5 File media/test/data/test-25fps.h264.md5 (right): https://codereview.chromium.org/2553653002/diff/1/media/test/data/test-25fps.h264.md5#newcode13 media/test/data/test-25fps.h264.md5:13: # ARM - Exynos Perhaps we should s/Exynos/Mali/
4 years ago (2016-12-06 07:40:00 UTC) #4
Pawel Osciak
https://codereview.chromium.org/2553653002/diff/1/media/test/data/test-25fps.h264.md5 File media/test/data/test-25fps.h264.md5 (right): https://codereview.chromium.org/2553653002/diff/1/media/test/data/test-25fps.h264.md5#newcode14 media/test/data/test-25fps.h264.md5:14: 82c979d493a00ee2188f7259230a8de9 Do we need to make a similar change ...
4 years ago (2016-12-06 07:41:41 UTC) #5
johnylin1
https://codereview.chromium.org/2553653002/diff/1/media/test/data/test-25fps.h264.md5 File media/test/data/test-25fps.h264.md5 (right): https://codereview.chromium.org/2553653002/diff/1/media/test/data/test-25fps.h264.md5#newcode14 media/test/data/test-25fps.h264.md5:14: 82c979d493a00ee2188f7259230a8de9 On 2016/12/06 07:41:40, Pawel Osciak wrote: > Do ...
4 years ago (2016-12-07 07:24:54 UTC) #7
Pawel Osciak
https://codereview.chromium.org/2553653002/diff/1/media/test/data/test-25fps.h264.md5 File media/test/data/test-25fps.h264.md5 (right): https://codereview.chromium.org/2553653002/diff/1/media/test/data/test-25fps.h264.md5#newcode14 media/test/data/test-25fps.h264.md5:14: 82c979d493a00ee2188f7259230a8de9 On 2016/12/07 07:24:54, johnylin1 wrote: > On 2016/12/06 ...
4 years ago (2016-12-07 07:36:39 UTC) #8
johnylin1
On 2016/12/05 17:43:57, xhwang wrote: > I am not familiar with this. But, if we ...
4 years ago (2016-12-07 08:48:02 UTC) #10
johnylin1
https://codereview.chromium.org/2553653002/diff/1/media/test/data/test-25fps.h264.md5 File media/test/data/test-25fps.h264.md5 (right): https://codereview.chromium.org/2553653002/diff/1/media/test/data/test-25fps.h264.md5#newcode14 media/test/data/test-25fps.h264.md5:14: 82c979d493a00ee2188f7259230a8de9 On 2016/12/07 07:36:39, Pawel Osciak wrote: > On ...
4 years ago (2016-12-07 08:48:17 UTC) #11
Pawel Osciak
lgtm
4 years ago (2016-12-07 09:17:01 UTC) #12
johnylin1
On 2016/12/07 08:48:02, johnylin1 wrote: > On 2016/12/05 17:43:57, xhwang wrote: > > I am ...
4 years ago (2016-12-07 12:24:08 UTC) #13
xhwang
thanks rs lgtm
4 years ago (2016-12-07 21:13:19 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2553653002/40001
4 years ago (2016-12-08 03:37:32 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/81905)
4 years ago (2016-12-08 05:15:10 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2553653002/40001
4 years ago (2016-12-08 06:17:27 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/82057)
4 years ago (2016-12-08 07:33:10 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2553653002/40001
4 years ago (2016-12-12 07:30:35 UTC) #24
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-12 09:06:09 UTC) #27
commit-bot: I haz the power
4 years ago (2016-12-12 15:11:08 UTC) #29
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/44e989098aaaddeb9f0ee857282bc8cdaa1cc3d1
Cr-Commit-Position: refs/heads/master@{#437835}

Powered by Google App Engine
This is Rietveld 408576698