Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: build/common.gypi

Issue 25535004: Remove ninja special cases for iOS build configurations. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 702135fd54dda83b2fedbea8d113dade39a0a8de..b7a8c3110a24f05c8a198b8339599c28b4825e7d 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -4199,12 +4199,10 @@
'xcode_settings': {
'SDKROOT': 'macosx<(mac_sdk)', # -isysroot
'MACOSX_DEPLOYMENT_TARGET': '<(mac_deployment_target)',
+ 'ARCHS': [
+ 'x86_64'
+ ],
},
- 'conditions': [
- ['"<(GENERATOR)"!="xcode"', {
- 'xcode_settings': { 'ARCHS': [ 'x86_64' ] },
- }],
- ],
}],
['_toolset=="target"', {
'xcode_settings': {
@@ -4213,13 +4211,6 @@
# instead set it here for target only.
'IPHONEOS_DEPLOYMENT_TARGET': '<(ios_deployment_target)',
},
- 'conditions': [
- ['target_arch=="armv7" and "<(GENERATOR)"!="xcode"', {
- 'xcode_settings': { 'ARCHS': [ 'armv7' ]},
- }, {
- 'xcode_settings': { 'ARCHS': [ 'i386' ] },
- }],
- ],
}],
['_type=="executable"', {
'configurations': {
@@ -4651,35 +4642,6 @@
],
}],
],
- 'configurations': {
- # DON'T ADD ANYTHING NEW TO THIS BLOCK UNLESS YOU REALLY REALLY NEED IT!
- # This block adds *project-wide* configuration settings to each project
- # file. It's almost always wrong to put things here. Specify your
- # custom |configurations| in target_defaults to add them to targets instead.
- 'conditions': [
- ['OS=="ios"', {
- 'Debug': {
- 'xcode_settings': {
- # Enable 'Build Active Architecture Only' for Debug. This
- # avoids a project-level warning in Xcode.
- # Note that this configuration uses the default VALID_ARCHS value
- # because if there is a device connected Xcode sets the active arch
- # to the arch of the device. In cases where the device's arch is not
- # in VALID_ARCHS (e.g. iPhone5 is armv7s) Xcode complains because it
- # can't determine what arch to compile for.
- 'ONLY_ACTIVE_ARCH': 'YES',
- },
- },
- 'Release': {
- 'xcode_settings': {
- # Override VALID_ARCHS and omit armv7s. Otherwise Xcode compiles for
- # both armv7 and armv7s, doubling the binary size.
- 'VALID_ARCHS': 'armv7 i386',
- },
- },
- }],
- ],
- },
'xcode_settings': {
# DON'T ADD ANYTHING NEW TO THIS BLOCK UNLESS YOU REALLY REALLY NEED IT!
# This block adds *project-wide* configuration settings to each project
@@ -4719,6 +4681,7 @@
['OS=="ios"', {
# Target both iPhone and iPad.
'TARGETED_DEVICE_FAMILY': '1,2',
+ 'VALID_ARCHS': 'armv7 i386',
}],
['target_arch=="x64"', {
'ARCHS': [
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698