Remove ninja special cases for iOS build configurations.

Remove ninja special cases for iOS build configurations.

Gyp now sets -iphoneos architecture, so armv7 switching isn't required in
common.gypi.  This CL also gets rid of ONLY_ACTIVE_ARCH, which requires full
rebuilds when switching devices between armv7, armv7s and arm64 devices.

Also remove the iOS5 arclite link step, which isn't needed in iOS6+.
 
BUG=312300
TEST=ios_rel_device builds

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231456
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231658

[justincohen, 2013-10-07 15:25:35]

To lliabraa@ for review, thakis for OWNERS, PTAL!

Ami, can you patch this in and make sure that this doesn't break you, assuming
you've moved to the new new gyp -iphoneos configuration directories.

Thanks!

[Nico, 2013-10-07 15:32:59]

https://codereview.chromium.org/25535004/diff/7001/build/common.gypi
File build/common.gypi (left):

https://codereview.chromium.org/25535004/diff/7001/build/common.gypi#oldcode4257
build/common.gypi:4257: ['clang==1', {
Don't you still need (bits of) this to build with chromium's clang? Or is that
just no longer supported?

[justincohen, 2013-10-07 16:08:02]

https://codereview.chromium.org/25535004/diff/7001/build/common.gypi
File build/common.gypi (left):

https://codereview.chromium.org/25535004/diff/7001/build/common.gypi#oldcode4257
build/common.gypi:4257: ['clang==1', {
None of this is needed anymore since we dropped iOS5 support -- we don't need to
link with arclite.

On 2013/10/07 15:33:00, Nico wrote:
> Don't you still need (bits of) this to build with chromium's clang? Or is that
> just no longer supported?

[Nico, 2013-10-07 16:37:17]

On 2013/10/07 16:08:02, justincohen wrote:
> https://codereview.chromium.org/25535004/diff/7001/build/common.gypi
> File build/common.gypi (left):
> 
>
https://codereview.chromium.org/25535004/diff/7001/build/common.gypi#oldcode4257
> build/common.gypi:4257: ['clang==1', {
> None of this is needed anymore since we dropped iOS5 support -- we don't need
to
> link with arclite.

Ah! Say that in the CL description then.

[justincohen, 2013-10-07 16:41:06]

Done, PTAL!

[Nico, 2013-10-07 16:44:33]

lgtm!

https://codereview.chromium.org/25535004/diff/7001/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/25535004/diff/7001/build/common.gypi#newcode4608
build/common.gypi:4608: # TODO(justincohen): Ninja only supports simulator for
now.
Is this still true?

[lliabraa, 2013-10-07 17:07:23]

LGTM for iOS

[Ami GONE FROM CHROMIUM, 2013-10-07 17:46:33]

per IM convo:  this change will break any builds that set target_arch to armv7
explicitly to get a device build in e.g. out/Debug instead of
out/Debug-iphoneos, so should probably hold off until everyone is on the new
-iphoneos scheme.

[(unused - use chromium), 2013-10-07 17:58:12]

On Mon, Oct 7, 2013 at 10:46 AM, <fischman@chromium.org> wrote:

> per IM convo:  this change will break any builds that set target_arch to
> armv7
> explicitly to get a device build in e.g. out/Debug instead of
> out/Debug-iphoneos, so should probably hold off until everyone is on the
> new
> -iphoneos scheme.
>

Who is "everyone" here? This is very leading-edge stuff as far as I
understand, so having lots of people depend on it isn't great as it slows
down changing things while they're still getting figured out.


>
>
https://codereview.chromium.**org/25535004/<https://codereview.chromium.org/2...
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Ami GONE FROM CHROMIUM, 2013-10-28 18:35:03]

LGTM as far as the effect of this on webrtc goes.

FTR this requires builds like webrtc that want to target iOS devices with an
explicit target_arch==armv7 to also use the out/{Debug,Release}-iphoneos
configuration.  It doesn't work to force target_arch==armv7 with the default
out/Debug configuration, which is forced to iphonesimulator by this CL.

https://codereview.chromium.org/25535004/diff/24001/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/25535004/diff/24001/build/common.gypi#newcode...
build/common.gypi:4607: # TODO(justincohen): Ninja only supports simulator for
now.
This is a lie?

[Ami GONE FROM CHROMIUM, 2013-10-28 18:40:36]

FTR https://webrtc-codereview.appspot.com/3059004/

[commit-bot: I haz the power, 2013-10-28 19:13:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/justincohen@google.com/25535004/24001

[commit-bot: I haz the power, 2013-10-28 19:38:04]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-10-28 21:30:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/justincohen@google.com/25535004/24001

[commit-bot: I haz the power, 2013-10-28 23:59:52]

Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

[commit-bot: I haz the power, 2013-10-29 00:02:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/justincohen@google.com/25535004/24001

[commit-bot: I haz the power, 2013-10-29 00:19:50]

Change committed as 231456

[commit-bot: I haz the power, 2013-10-29 22:19:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/justincohen@google.com/25535004/24001

[commit-bot: I haz the power, 2013-10-29 22:31:52]

Change committed as 231658