Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2553293002: DevTools: add tooltip for truncated classnames and full name for title (Closed)

Created:
4 years ago by luoe
Modified:
4 years ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: add tooltip for truncated classnames and full name for title This CL adds a tooltip for name abbreviations and no longer truncates the object name when it is the title. Long names in previews are still truncated. BUG=667614 Committed: https://crrev.com/aa907d22729b4080eb1f3b15f0296b27799cfba0 Cr-Commit-Position: refs/heads/master@{#439024}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -5 lines) Patch
M third_party/WebKit/LayoutTests/inspector/console/console-format.html View 1 chunk +6 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-format-expected.txt View 3 chunks +15 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/RemoteObjectPreviewFormatter.js View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 23 (16 generated)
luoe
Please take a look
4 years ago (2016-12-06 23:41:53 UTC) #3
lushnikov
lgtm
4 years ago (2016-12-13 23:24:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2553293002/1
4 years ago (2016-12-15 18:45:41 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/357307)
4 years ago (2016-12-15 21:00:07 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2553293002/1
4 years ago (2016-12-16 03:29:32 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-16 04:40:40 UTC) #21
commit-bot: I haz the power
4 years ago (2016-12-16 04:42:41 UTC) #23
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aa907d22729b4080eb1f3b15f0296b27799cfba0
Cr-Commit-Position: refs/heads/master@{#439024}

Powered by Google App Engine
This is Rietveld 408576698