Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(719)

Issue 2553183002: Reland of ui/gl: Initialize the ANGLE Platform on all configurations (Closed)

Created:
4 years ago by Corentin Wallez
Modified:
4 years ago
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of ui/gl: Initialize the ANGLE Platform on all configurations (patchset #1 id:1 of https://codereview.chromium.org/2548253003/ ) Reason for revert: If the commit did indeed cause the failure, then a rebaseline will be needed. Original issue's description: > Revert of ui/gl: Initialize the ANGLE Platform on all configurations (patchset #5 id:80001 of https://codereview.chromium.org/2491993002/ ) > > Reason for revert: > Unlikely suspect for flaky failure of contrast-hw WebKit test see https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20%28dbg%29/builds/185 > > Original issue's description: > > ui/gl: Initialize the ANGLE Platform on all EGL configurations > > > > BUG=angleproject:1621 > > > > Committed: https://crrev.com/b2223ac7d08f5aa62e1d0c6268507142e86ef098 > > Cr-Commit-Position: refs/heads/master@{#436334} > > TBR=kbr@chromium.org,thakis@chromium.org,zmo@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=angleproject:1621 > > Committed: https://crrev.com/6c1a3ab469ad86fd49c8d97ede4a6b96a49ca5f6 > Cr-Commit-Position: refs/heads/master@{#436421} TBR=kbr@chromium.org,thakis@chromium.org,zmo@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=angleproject:1621 Committed: https://crrev.com/faad02c35f3323bcb103c88dde41217a2c5baebd Cr-Commit-Position: refs/heads/master@{#436620}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -35 lines) Patch
M ui/gl/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gl/egl_api_unittest.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M ui/gl/gl_surface_egl.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_surface_egl.cc View 5 chunks +22 lines, -1 line 0 comments Download
M ui/gl/init/gl_initializer_android.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gl/init/gl_initializer_ozone.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gl/init/gl_initializer_win.cc View 5 chunks +1 line, -30 lines 0 comments Download
M ui/gl/init/gl_initializer_x11.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/ozone/common/gl_ozone_egl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Corentin Wallez
Created Reland of ui/gl: Initialize the ANGLE Platform on all configurations
4 years ago (2016-12-06 16:52:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2553183002/1
4 years ago (2016-12-06 16:52:43 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-06 16:53:59 UTC) #5
commit-bot: I haz the power
4 years ago (2016-12-06 16:56:29 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/faad02c35f3323bcb103c88dde41217a2c5baebd
Cr-Commit-Position: refs/heads/master@{#436620}

Powered by Google App Engine
This is Rietveld 408576698