Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 2553173004: Remove PlatformClientAuth interface from upstream. (Closed)

Created:
4 years ago by ryanchung
Modified:
4 years ago
Reviewers:
dougsteed, maclellant, alokp
CC:
chromium-reviews, alokp+watch_chromium.org, lcwu+watch_chromium.org, halliwell+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove PlatformClientAuth interface from upstream. Moving it to the internal certificate code. This allows internal certificate code to break dependency on cc/common. BUG=665489 Committed: https://crrev.com/4ad924db876e1ee8c8cacb3ca03c484ee75cd4ce Cr-Commit-Position: refs/heads/master@{#439245}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -64 lines) Patch
M chromecast/browser/cast_browser_main_parts.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M chromecast/common/BUILD.gn View 2 chunks +0 lines, -19 lines 0 comments Download
D chromecast/common/platform_client_auth.h View 1 chunk +0 lines, -23 lines 0 comments Download
D chromecast/common/platform_client_auth_simple.cc View 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
ryanchung
4 years ago (2016-12-16 00:31:14 UTC) #2
alokp
lgtm
4 years ago (2016-12-16 05:56:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2553173004/1
4 years ago (2016-12-16 22:18:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-17 00:15:09 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-17 00:16:53 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4ad924db876e1ee8c8cacb3ca03c484ee75cd4ce
Cr-Commit-Position: refs/heads/master@{#439245}

Powered by Google App Engine
This is Rietveld 408576698