third_party/WebKit/Source/devtools/front_end/resources/ApplicationCacheItemsView.js - Issue 2553043003: [DevTools] Remove methods on Common.Event.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/resources/ApplicationCacheItemsView.js

Issue 2553043003: [DevTools] Remove methods on Common.Event. (Closed)

Patch Set: rebased Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js ('k') | third_party/WebKit/Source/devtools/front_end/resources/CookieItemsView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/resources/ApplicationCacheItemsView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/resources/ApplicationCacheItemsView.js b/third_party/WebKit/Source/devtools/front_end/resources/ApplicationCacheItemsView.js

index fbe91d0818b086f34e695d93716b028b27c026ac..f154fd658778514d4f2344e7bd477f88ed08e590 100644

--- a/third_party/WebKit/Source/devtools/front_end/resources/ApplicationCacheItemsView.js

+++ b/third_party/WebKit/Source/devtools/front_end/resources/ApplicationCacheItemsView.js

@@ -36,7 +36,7 @@ Resources.ApplicationCacheItemsView = class extends UI.SimpleView {

this._deleteButton = new UI.ToolbarButton(Common.UIString('Delete'), 'largeicon-delete');

this._deleteButton.setVisible(false);

- this._deleteButton.addEventListener('click', this._deleteButtonClicked, this);

+ this._deleteButton.addEventListener(UI.ToolbarButton.Events.Click, this._deleteButtonClicked, this);

this._connectivityIcon = createElement('label', 'dt-icon-label');

this._connectivityIcon.style.margin = '0 2px 0 5px';

@@ -239,6 +239,9 @@ Resources.ApplicationCacheItemsView = class extends UI.SimpleView {

this._dataGrid.rootNode().children[0].selected = true;

}

+ /**

+ * @param {!Common.Event} event

+ */

_deleteButtonClicked(event) {

if (!this._dataGrid || !this._dataGrid.selectedNode)

return;