Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2553033003: Add xdisplaycheck back until //build dependency is removed (Closed)

Created:
4 years ago by Tom (Use chromium acct)
Modified:
4 years ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add xdisplaycheck back until //build dependency is removed BUG=670470 R=dpranke@chromium.org Committed: https://crrev.com/af830f3a656f8895dcdd30239e074e5521c313ee Cr-Commit-Position: refs/heads/master@{#436864}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -0 lines) Patch
M BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
A tools/xdisplaycheck/BUILD.gn View 1 chunk +15 lines, -0 lines 0 comments Download
A tools/xdisplaycheck/xdisplaycheck.cc View 1 chunk +119 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Tom (Use chromium acct)
dpranke@ PTAL I guess the dependency in //build/scripts/slave/xvfb.py is real? //build/scripts/slaves/runtest.py uses it. However, I ...
4 years ago (2016-12-07 03:18:41 UTC) #5
Dirk Pranke
lgtm.
4 years ago (2016-12-07 03:35:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2553033003/1
4 years ago (2016-12-07 04:47:56 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-07 04:52:29 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-07 04:54:26 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/af830f3a656f8895dcdd30239e074e5521c313ee
Cr-Commit-Position: refs/heads/master@{#436864}

Powered by Google App Engine
This is Rietveld 408576698