Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 2552923002: [DevTools] call setScriptSource callback right after editing (Closed)

Created:
4 years ago by kozy
Modified:
4 years ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] call setScriptSource callback right after editing Frontend should have time to restore breakpoints before stepInto call. BUG=none R=dgozman@chromium.org Committed: https://crrev.com/4b204033a7234619dede6a09f34c0b0e2db49b5a Cr-Commit-Position: refs/heads/master@{#436507}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -13 lines) Patch
M third_party/WebKit/LayoutTests/inspector/sources/debugger/live-edit.html View 3 chunks +4 lines, -3 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/sources/debugger/resources/edit-me-2.js View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js View 3 chunks +2 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kozy
Dmitry, please take a look.
4 years ago (2016-12-06 00:12:35 UTC) #1
dgozman
lgtm
4 years ago (2016-12-06 01:21:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2552923002/1
4 years ago (2016-12-06 01:30:42 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-06 03:19:20 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-06 03:22:51 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4b204033a7234619dede6a09f34c0b0e2db49b5a
Cr-Commit-Position: refs/heads/master@{#436507}

Powered by Google App Engine
This is Rietveld 408576698