Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js

Issue 2552923002: [DevTools] call setScriptSource callback right after editing (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/sources/debugger/resources/edit-me-2.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js b/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js
index 788c5dd790e1f95288834e36efd5d05f8b3ab723..7312c980c7ab6079828771caea67357f30162114 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js
@@ -376,9 +376,9 @@ SDK.DebuggerModel = class extends SDK.SDKModel {
callFrames,
asyncStackTrace,
needsStepIn) {
+ callback(error, exceptionDetails);
if (needsStepIn) {
this.stepInto();
- this._pendingLiveEditCallback = callback.bind(this, error, exceptionDetails);
return;
}
@@ -387,7 +387,6 @@ SDK.DebuggerModel = class extends SDK.SDKModel {
callFrames, this._debuggerPausedDetails.reason, this._debuggerPausedDetails.auxData,
this._debuggerPausedDetails.breakpointIds, asyncStackTrace);
}
- callback(error, exceptionDetails);
}
/**
@@ -435,15 +434,8 @@ SDK.DebuggerModel = class extends SDK.SDKModel {
_pausedScript(callFrames, reason, auxData, breakpointIds, asyncStackTrace) {
var pausedDetails =
new SDK.DebuggerPausedDetails(this, callFrames, reason, auxData, breakpointIds, asyncStackTrace);
- if (this._setDebuggerPausedDetails(pausedDetails)) {
- if (this._pendingLiveEditCallback) {
- var callback = this._pendingLiveEditCallback;
- delete this._pendingLiveEditCallback;
- callback();
- }
- } else {
+ if (!this._setDebuggerPausedDetails(pausedDetails))
this._agent.stepInto();
- }
}
_resumedScript() {
« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/sources/debugger/resources/edit-me-2.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698