Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Issue 2552903002: Revert of cc: Build Image to Region map during image meta-data generation. (patchset #6 id:100001 o… (Closed)

Created:
4 years ago by vmiura
Modified:
4 years ago
Reviewers:
vmpstr, Khushal
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Revert of cc: Build Image to Region map during image meta-data generation. (patchset #6 id:100001 of https://codereview.chromium.org/2496283004/ ) Reason for revert: Computing these image regions adds significant time to the critical path on image heavy content. Let's re-land after addressing the performance. BUG=670926 Original issue's description: > cc: Build Image to Region map during image meta-data generation. > > During the discardable image meta-data generation phase, we build an > Rtree to pull the set of images given a rect. This change adds a > reverse lookup map to be built at the same time for querying the region > for an image in a DisplayItemList. > > BUG=665266 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel > > Committed: https://crrev.com/fc85c1aa0881047c4410cbedc1e4543bcf789a1f > Cr-Commit-Position: refs/heads/master@{#432841} TBR=vmpstr@chromium.org,khushalsagar@chromium.org BUG=665266 Review-Url: https://codereview.chromium.org/2551583003 Cr-Commit-Position: refs/heads/master@{#436174} (cherry picked from commit 654417a5699ed0965a94977350266bf5ce206daa) Committed: https://chromium.googlesource.com/chromium/src/+/c006456e1c0057757977351133fd7bb2e5275b90

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -82 lines) Patch
M cc/playback/discardable_image_map.h View 4 chunks +0 lines, -8 lines 0 comments Download
M cc/playback/discardable_image_map.cc View 4 chunks +3 lines, -16 lines 0 comments Download
M cc/playback/discardable_image_map_unittest.cc View 10 chunks +0 lines, -53 lines 0 comments Download
M cc/playback/display_item_list.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/playback/display_item_list.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
vmiura
4 years ago (2016-12-06 00:09:37 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c006456e1c0057757977351133fd7bb2e5275b90.

Powered by Google App Engine
This is Rietveld 408576698