Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2551583003: Revert of cc: Build Image to Region map during image meta-data generation. (Closed)

Created:
4 years ago by vmiura
Modified:
4 years ago
Reviewers:
vmpstr, Khushal
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of cc: Build Image to Region map during image meta-data generation. (patchset #6 id:100001 of https://codereview.chromium.org/2496283004/ ) Reason for revert: Computing these image regions adds significant time to the critical path on image heavy content. Let's re-land after addressing the performance. BUG=670926 Original issue's description: > cc: Build Image to Region map during image meta-data generation. > > During the discardable image meta-data generation phase, we build an > Rtree to pull the set of images given a rect. This change adds a > reverse lookup map to be built at the same time for querying the region > for an image in a DisplayItemList. > > BUG=665266 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel > > Committed: https://crrev.com/fc85c1aa0881047c4410cbedc1e4543bcf789a1f > Cr-Commit-Position: refs/heads/master@{#432841} TBR=vmpstr@chromium.org,khushalsagar@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=665266 Committed: https://crrev.com/654417a5699ed0965a94977350266bf5ce206daa Cr-Commit-Position: refs/heads/master@{#436174}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -82 lines) Patch
M cc/playback/discardable_image_map.h View 4 chunks +0 lines, -8 lines 0 comments Download
M cc/playback/discardable_image_map.cc View 4 chunks +3 lines, -16 lines 0 comments Download
M cc/playback/discardable_image_map_unittest.cc View 10 chunks +0 lines, -53 lines 0 comments Download
M cc/playback/display_item_list.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/playback/display_item_list.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
vmiura
Created Revert of cc: Build Image to Region map during image meta-data generation.
4 years ago (2016-12-03 04:07:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2551583003/1
4 years ago (2016-12-03 04:07:24 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-03 21:10:27 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-03 21:12:06 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/654417a5699ed0965a94977350266bf5ce206daa
Cr-Commit-Position: refs/heads/master@{#436174}

Powered by Google App Engine
This is Rietveld 408576698