Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 2552893005: Add ColorBehavior to GraphicsLayer and GraphicsContext (Closed)

Created:
4 years ago by ccameron
Modified:
4 years ago
Reviewers:
pdr.
CC:
chromium-reviews, krit, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, pdr+graphicswatchlist_chromium.org, jbroman, Justin Novosad, blink-layers+watch_chromium.org, Rik, f(malita), blink-reviews, danakj+watch_chromium.org, ajuma+watch_chromium.org, Stephen Chennney, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add ColorBehavior to GraphicsLayer and GraphicsContext Specify the ColorBehavior from GraphicsLayer to GraphicsContext. Use the GraphicsLayer's ColorBehavior to determine if the WebDisplayItemList has an implied color space. This does not change any behavior, but makes implied behavior explicit. The ColorBehavior in GraphicsLayer is unused, but will be used by future patches. BUG=667411 Committed: https://crrev.com/a9ee0245d3f3207903200bcde863021f04b6e704 Cr-Commit-Position: refs/heads/master@{#437648}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Remove dependencies #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -11 lines) Patch
M third_party/WebKit/Source/platform/graphics/ContentLayerDelegate.cpp View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsContext.h View 4 chunks +9 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayer.h View 3 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp View 1 2 3 3 chunks +11 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 26 (18 generated)
ccameron
ptal -- some preliminary plumbing before bigger changes
4 years ago (2016-12-08 02:59:32 UTC) #6
ccameron
ping
4 years ago (2016-12-08 21:39:17 UTC) #11
ccameron
ping
4 years ago (2016-12-09 18:33:29 UTC) #15
pdr.
On 2016/12/09 at 18:33:29, ccameron wrote: > ping LGTM
4 years ago (2016-12-09 19:21:00 UTC) #17
ccameron
Thanks!
4 years ago (2016-12-09 20:33:36 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2552893005/60001
4 years ago (2016-12-09 20:34:18 UTC) #21
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years ago (2016-12-09 21:01:29 UTC) #24
commit-bot: I haz the power
4 years ago (2016-12-12 14:40:43 UTC) #26
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/a9ee0245d3f3207903200bcde863021f04b6e704
Cr-Commit-Position: refs/heads/master@{#437648}

Powered by Google App Engine
This is Rietveld 408576698