Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2552893003: Revert of [turbofan] Add --csa-verify flag that enables machine graph verification of code stubs. (Closed)

Created:
4 years ago by Igor Sheludko
Modified:
4 years ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] Add --csa-verify flag that enables machine graph verification of code stubs. (patchset #2 id:60001 of https://codereview.chromium.org/2551933002/ ) Reason for revert: Broke nosnap build: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug/builds/10689 Original issue's description: > [turbofan] Add --csa-verify flag that enables machine graph verification of code stubs. > > The flag must be used only by CodeStubAssemblerGraphsCorrectness cctest for now > and once all the verification issues are fixed the flag will be enabled in debug > mode by default. > > BUG= > > Committed: https://crrev.com/292b3548f6d02b964b4afe3e05f89c0681fa5620 > Cr-Commit-Position: refs/heads/master@{#41531} TBR=mstarzinger@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/a9345a158ad40df5edaabc692d1884b3db28c749 Cr-Commit-Position: refs/heads/master@{#41532}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -49 lines) Patch
M src/compiler/pipeline.cc View 1 chunk +4 lines, -9 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-code-stub-assembler.cc View 1 chunk +0 lines, -39 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Igor Sheludko
Created Revert of [turbofan] Add --csa-verify flag that enables machine graph verification of code stubs.
4 years ago (2016-12-06 17:28:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2552893003/1
4 years ago (2016-12-06 17:28:40 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-06 17:28:54 UTC) #5
commit-bot: I haz the power
4 years ago (2016-12-06 17:29:23 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a9345a158ad40df5edaabc692d1884b3db28c749
Cr-Commit-Position: refs/heads/master@{#41532}

Powered by Google App Engine
This is Rietveld 408576698