Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1453)

Unified Diff: test/cctest/test-code-stub-assembler.cc

Issue 2552893003: Revert of [turbofan] Add --csa-verify flag that enables machine graph verification of code stubs. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/flag-definitions.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-code-stub-assembler.cc
diff --git a/test/cctest/test-code-stub-assembler.cc b/test/cctest/test-code-stub-assembler.cc
index 827dfb7ef05eea4b62b7fd4e4aaf79a803bc00d6..8657819c60eea82bc158313875fe75f21f014efc 100644
--- a/test/cctest/test-code-stub-assembler.cc
+++ b/test/cctest/test-code-stub-assembler.cc
@@ -1927,44 +1927,5 @@
isolate->heap()->undefined_value(), Smi::FromInt(6), 6, 4);
}
-TEST(CodeStubAssemblerGraphsCorrectness) {
- // The test does not work with interpreter because bytecode handlers taken
- // from the snapshot already refer to precompiled stubs from the snapshot
- // and there is no way to trigger bytecode handlers recompilation.
- if (i::FLAG_ignition || i::FLAG_turbo) return;
-
- i::FLAG_csa_verify = true;
-
- v8::Isolate::CreateParams create_params;
- create_params.array_buffer_allocator = CcTest::array_buffer_allocator();
- v8::Isolate* isolate = v8::Isolate::New(create_params);
- i::Isolate* i_isolate = reinterpret_cast<i::Isolate*>(isolate);
-
- {
- v8::Isolate::Scope isolate_scope(isolate);
- LocalContext env(isolate);
- v8::HandleScope scope(isolate);
-
- {
- // Enforce recompilation of the following stubs.
- i::CodeStub::Major code_stub_keys[] = {
- i::CodeStub::LoadIC, i::CodeStub::LoadICTrampoline,
- i::CodeStub::LoadGlobalIC, i::CodeStub::LoadGlobalICTrampoline,
- i::CodeStub::KeyedLoadICTF, i::CodeStub::KeyedLoadICTrampolineTF,
- i::CodeStub::StoreIC, i::CodeStub::StoreICTrampoline,
- i::CodeStub::KeyedStoreICTF, i::CodeStub::KeyedStoreICTrampolineTF,
- };
- i::Heap* heap = i_isolate->heap();
- i::Handle<i::UnseededNumberDictionary> dict(heap->code_stubs());
- for (size_t i = 0; i < arraysize(code_stub_keys); i++) {
- dict = i::UnseededNumberDictionary::DeleteKey(dict, code_stub_keys[i]);
- }
- heap->SetRootCodeStubs(*dict);
- }
- // Generate some stubs here.
- }
- isolate->Dispose();
-}
-
} // namespace internal
} // namespace v8
« no previous file with comments | « src/flag-definitions.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698