Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2552883011:
Allow user to scale NTP internals pages (Closed)
DescriptionAllow user to scale NTP internals pages
Applies to:
* chrome://snippets-internals/
* chrome://popular-sites-internals/
It's nice to start the user off at zoom 1.0, but there's no good reason
to disallow zooming in further.
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/9125640c6b787e809213336bef3f5eecf12d1a15
Cr-Commit-Position: refs/heads/master@{#437866}
Patch Set 1 #
Messages
Total messages: 31 (17 generated)
Description was changed from ========== Allow user to scale NTP internals pages Applies to: * chrome://snippets-internals/ * chrome://popular-sites-internals/ It's nice to start the user off at zoom 1.0, but there's no good reason to disallow zooming in further. BUG=none ========== to ========== Allow user to scale NTP internals pages Applies to: * chrome://snippets-internals/ * chrome://popular-sites-internals/ It's nice to start the user off at zoom 1.0, but there's no good reason to disallow zooming in further. BUG=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
sfiera@chromium.org changed reviewers: + noyau@chromium.org
The CQ bit was checked by sfiera@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by sfiera@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
sfiera@chromium.org changed reviewers: + treib@chromium.org
+jkrcal for ntp_snippets approval
sfiera@chromium.org changed reviewers: + jkrcal@chromium.org - treib@chromium.org
+jkrcal for ntp_snippets approval
lgtm
The CQ bit was checked by sfiera@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
sfiera@chromium.org changed reviewers: + bauerb@chromium.org
Ah, right, the snippets webui HTML is not actually owned by the snippets owners (can we change that?). +bauerb for real approval.
lgtm
The CQ bit was checked by sfiera@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481545974972610, "parent_rev":
"8afa73099784d41043bf152cad2cced8923bbc6b", "commit_rev":
"8cfd31343366b0b905a1965fe07a1ef50413ebf3"}
Message was sent while issue was closed.
Description was changed from ========== Allow user to scale NTP internals pages Applies to: * chrome://snippets-internals/ * chrome://popular-sites-internals/ It's nice to start the user off at zoom 1.0, but there's no good reason to disallow zooming in further. BUG=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Allow user to scale NTP internals pages Applies to: * chrome://snippets-internals/ * chrome://popular-sites-internals/ It's nice to start the user off at zoom 1.0, but there's no good reason to disallow zooming in further. BUG=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2552883011 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Allow user to scale NTP internals pages Applies to: * chrome://snippets-internals/ * chrome://popular-sites-internals/ It's nice to start the user off at zoom 1.0, but there's no good reason to disallow zooming in further. BUG=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2552883011 ========== to ========== Allow user to scale NTP internals pages Applies to: * chrome://snippets-internals/ * chrome://popular-sites-internals/ It's nice to start the user off at zoom 1.0, but there's no good reason to disallow zooming in further. BUG=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/9125640c6b787e809213336bef3f5eecf12d1a15 Cr-Commit-Position: refs/heads/master@{#437866} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/9125640c6b787e809213336bef3f5eecf12d1a15 Cr-Commit-Position: refs/heads/master@{#437866} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
