Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 2552883003: media: Pare MCVD down to a minimal media::VideoDecoder (Closed)

Created:
4 years ago by watk
Modified:
4 years ago
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Pare MCVD down to a minimal media::VideoDecoder Originally the plan was to iterate on MCVD by starting with AVDA and deleting/refactoring, but that didn't turn out well. The diffs were noisy and it was a lot of work to keep it building. Now we're changing direction and building MCVD from the ground up, taking pieces of AVDA where necessary. It builds and comes with a minimal unittest. BUG=660942 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/8897c835c2c252898b58b479dc6f5a514bd0edfc Cr-Commit-Position: refs/heads/master@{#436733}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -1442 lines) Patch
M media/base/test_helpers.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/base/test_helpers.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M media/gpu/BUILD.gn View 3 chunks +16 lines, -0 lines 0 comments Download
M media/gpu/android/media_codec_video_decoder.h View 1 chunk +17 lines, -233 lines 0 comments Download
M media/gpu/android/media_codec_video_decoder.cc View 3 chunks +30 lines, -1209 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
watk
You can just look at the RHS because the result is pretty trivial.
4 years ago (2016-12-06 03:44:13 UTC) #5
sandersd (OOO until July 31)
lgtm
4 years ago (2016-12-06 19:22:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2552883003/1
4 years ago (2016-12-06 21:06:40 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-06 21:26:17 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-06 21:29:06 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8897c835c2c252898b58b479dc6f5a514bd0edfc
Cr-Commit-Position: refs/heads/master@{#436733}

Powered by Google App Engine
This is Rietveld 408576698