Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2552813002:
Overlay scrollbars shouldn't fade out while mouse is over/near. (Closed)
DescriptionOverlay scrollbars shouldn't fade out while mouse is over/near.
BUG=669668
TEST=ScrollbarAnimationControllerThinningTest.DontFadeAfterReleasedNear,
ScrollbarAnimationControllerThinningTest.FadeAfterReleasedFar,
ScrollbarAnimationControllerThinningTest.MoveNearAndDontFadeOut,
ScrollbarAnimationControllerThinningTest.MoveOverAndDontFadeOut
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
Committed: https://crrev.com/58293adb8e9ecc80e2044aa96a962bc2e7e19fb3
Cr-Commit-Position: refs/heads/master@{#437585}
Patch Set 1 #
Total comments: 6
Patch Set 2 : unittests polished #
Total comments: 1
Patch Set 3 : removed braces #
Messages
Total messages: 33 (26 generated)
Description was changed from ========== Overlay scrollbars shouldn't fade out while mouse is over/near. BUG=669668 TEST=ScrollbarAnimationControllerThinningTest.DontFadeAfterReleasedNear, ScrollbarAnimationControllerThinningTest.FadeAfterReleasedFar, ScrollbarAnimationControllerThinningTest.MoveNearAndDontFadeOut, ScrollbarAnimationControllerThinningTest.MoveOverAndDontFadeOut ========== to ========== Overlay scrollbars shouldn't fade out while mouse is over/near. BUG=669668 TEST=ScrollbarAnimationControllerThinningTest.DontFadeAfterReleasedNear, ScrollbarAnimationControllerThinningTest.FadeAfterReleasedFar, ScrollbarAnimationControllerThinningTest.MoveNearAndDontFadeOut, ScrollbarAnimationControllerThinningTest.MoveOverAndDontFadeOut CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ==========
The CQ bit was checked by sahel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Overlay scrollbars shouldn't fade out while mouse is over/near. BUG=669668 TEST=ScrollbarAnimationControllerThinningTest.DontFadeAfterReleasedNear, ScrollbarAnimationControllerThinningTest.FadeAfterReleasedFar, ScrollbarAnimationControllerThinningTest.MoveNearAndDontFadeOut, ScrollbarAnimationControllerThinningTest.MoveOverAndDontFadeOut CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ========== to ========== Overlay scrollbars shouldn't fade out while mouse is over/near. BUG=669668 TEST=ScrollbarAnimationControllerThinningTest.DontFadeAfterReleasedNear, ScrollbarAnimationControllerThinningTest.FadeAfterReleasedFar, ScrollbarAnimationControllerThinningTest.MoveNearAndDontFadeOut, ScrollbarAnimationControllerThinningTest.MoveOverAndDontFadeOut CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ==========
sahel@chromium.org changed reviewers: + bokan@chromium.org
Some suggested improvements in test but lgtm otherwise. Note, you'll still need to fix this for non-composited scrollers but it's fine to do in a separate patch (especially since they don't fade out at all currently due to crbug.com/671218) https://codereview.chromium.org/2552813002/diff/1/cc/input/scrollbar_animatio... File cc/input/scrollbar_animation_controller_thinning_unittest.cc (right): https://codereview.chromium.org/2552813002/diff/1/cc/input/scrollbar_animatio... cc/input/scrollbar_animation_controller_thinning_unittest.cc:235: EXPECT_TRUE(client_.start_fade().IsCancelled()); Merge all occurances of this !is_null and IsCanceled into an OR, we expect that start_fade is either NULL or Canceled (it wouldn't be a problem if we cleared start_fade as well as cancelled it, right?) https://codereview.chromium.org/2552813002/diff/1/cc/input/scrollbar_animatio... cc/input/scrollbar_animation_controller_thinning_unittest.cc:362: scrollbar_controller_->DidMouseMoveNear(26); Use kDefaultMouseMoveDistanceToTriggerAnimation + 1 https://codereview.chromium.org/2552813002/diff/1/cc/input/scrollbar_animatio... cc/input/scrollbar_animation_controller_thinning_unittest.cc:520: // An animation for the fade should have been enqueued and cancelled, since We shouldn't test that's its enqueued anymore. Only that it's cancelled or null.
Patchset #2 (id:20001) has been deleted
The CQ bit was checked by sahel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
sahel@chromium.org changed reviewers: + aelias@chromium.org
aelias@chromium.org: Please review changes in https://codereview.chromium.org/2552813002/diff/1/cc/input/scrollbar_animatio... File cc/input/scrollbar_animation_controller_thinning_unittest.cc (right): https://codereview.chromium.org/2552813002/diff/1/cc/input/scrollbar_animatio... cc/input/scrollbar_animation_controller_thinning_unittest.cc:235: EXPECT_TRUE(client_.start_fade().IsCancelled()); On 2016/12/06 17:22:28, bokan wrote: > Merge all occurances of this !is_null and IsCanceled into an OR, we expect that > start_fade is either NULL or Canceled (it wouldn't be a problem if we cleared > start_fade as well as cancelled it, right?) right, done. https://codereview.chromium.org/2552813002/diff/1/cc/input/scrollbar_animatio... cc/input/scrollbar_animation_controller_thinning_unittest.cc:362: scrollbar_controller_->DidMouseMoveNear(26); On 2016/12/06 17:22:28, bokan wrote: > Use kDefaultMouseMoveDistanceToTriggerAnimation + 1 Done. https://codereview.chromium.org/2552813002/diff/1/cc/input/scrollbar_animatio... cc/input/scrollbar_animation_controller_thinning_unittest.cc:520: // An animation for the fade should have been enqueued and cancelled, since On 2016/12/06 17:22:28, bokan wrote: > We shouldn't test that's its enqueued anymore. Only that it's cancelled or null. Done.
lgtm https://codereview.chromium.org/2552813002/diff/40001/cc/input/scrollbar_anim... File cc/input/scrollbar_animation_controller_thinning.cc (right): https://codereview.chromium.org/2552813002/diff/40001/cc/input/scrollbar_anim... cc/input/scrollbar_animation_controller_thinning.cc:75: if (!mouse_is_near_scrollbar_) { nit: no braces for this in Chromium style
The CQ bit was checked by sahel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by sahel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by sahel@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bokan@chromium.org, aelias@chromium.org Link to the patchset: https://codereview.chromium.org/2552813002/#ps60001 (title: "removed braces")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481301864303960,
"parent_rev": "0e1f350f035e5c4f6faeb6597c93fc9ecb5e9cdc", "commit_rev":
"99fd50b1041a1360ed9c599f89c321046a19ad8d"}
Message was sent while issue was closed.
Description was changed from ========== Overlay scrollbars shouldn't fade out while mouse is over/near. BUG=669668 TEST=ScrollbarAnimationControllerThinningTest.DontFadeAfterReleasedNear, ScrollbarAnimationControllerThinningTest.FadeAfterReleasedFar, ScrollbarAnimationControllerThinningTest.MoveNearAndDontFadeOut, ScrollbarAnimationControllerThinningTest.MoveOverAndDontFadeOut CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ========== to ========== Overlay scrollbars shouldn't fade out while mouse is over/near. BUG=669668 TEST=ScrollbarAnimationControllerThinningTest.DontFadeAfterReleasedNear, ScrollbarAnimationControllerThinningTest.FadeAfterReleasedFar, ScrollbarAnimationControllerThinningTest.MoveNearAndDontFadeOut, ScrollbarAnimationControllerThinningTest.MoveOverAndDontFadeOut CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2552813002 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Overlay scrollbars shouldn't fade out while mouse is over/near. BUG=669668 TEST=ScrollbarAnimationControllerThinningTest.DontFadeAfterReleasedNear, ScrollbarAnimationControllerThinningTest.FadeAfterReleasedFar, ScrollbarAnimationControllerThinningTest.MoveNearAndDontFadeOut, ScrollbarAnimationControllerThinningTest.MoveOverAndDontFadeOut CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2552813002 ========== to ========== Overlay scrollbars shouldn't fade out while mouse is over/near. BUG=669668 TEST=ScrollbarAnimationControllerThinningTest.DontFadeAfterReleasedNear, ScrollbarAnimationControllerThinningTest.FadeAfterReleasedFar, ScrollbarAnimationControllerThinningTest.MoveNearAndDontFadeOut, ScrollbarAnimationControllerThinningTest.MoveOverAndDontFadeOut CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Committed: https://crrev.com/58293adb8e9ecc80e2044aa96a962bc2e7e19fb3 Cr-Commit-Position: refs/heads/master@{#437585} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/58293adb8e9ecc80e2044aa96a962bc2e7e19fb3 Cr-Commit-Position: refs/heads/master@{#437585} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
