components/crash/content/app/breakpad_linux.h - Issue 2552753002: Do not generate a microdump if there are no webview pointers on the stack.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/crash/content/app/breakpad_linux.h

Issue 2552753002: Do not generate a microdump if there are no webview pointers on the stack. (Closed)

Patch Set: set suppression flag Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/crash/content/app/breakpad_linux.h

diff --git a/components/crash/content/app/breakpad_linux.h b/components/crash/content/app/breakpad_linux.h

index 3316fa0cbe6c146c601b8a3b869963d9c554b5e7..03de68aa083691cf664ac512dd0905d507318b3a 100644

--- a/components/crash/content/app/breakpad_linux.h

+++ b/components/crash/content/app/breakpad_linux.h

@@ -31,6 +31,7 @@ extern void InitMicrodumpCrashHandlerIfNecessary(

extern void AddGpuFingerprintToMicrodumpCrashHandler(

const std::string& gpu_fingerprint);

+extern void SetWebViewTextAddrRange(uintptr_t start, uintptr_t end);

Torne 2016/12/05 15:19:32 Maybe call this SetNativeCodeTextAddrRange or some

Robert Sesek 2016/12/05 16:19:18 Please comment this as well, so that it's clear wh

Tobias Sargeant 2016/12/06 16:48:33 Done.

Tobias Sargeant 2016/12/06 16:48:33 Edit.

#endif

// Checks if crash reporting is enabled. Note that this is not the same as