Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2426)

Unified Diff: android_webview/lib/main/aw_main_delegate.cc

Issue 2552753002: Do not generate a microdump if there are no webview pointers on the stack. (Closed)
Patch Set: set suppression flag Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/lib/main/aw_main_delegate.cc
diff --git a/android_webview/lib/main/aw_main_delegate.cc b/android_webview/lib/main/aw_main_delegate.cc
index 3c91dc748dbc69bab0fe1a56e7ea1f998f0b004f..3870d58e6afac371ba2a3c19e3b28e0fc225c7e2 100644
--- a/android_webview/lib/main/aw_main_delegate.cc
+++ b/android_webview/lib/main/aw_main_delegate.cc
@@ -46,6 +46,9 @@
#include "ui/base/resource/resource_bundle.h"
#include "ui/events/gesture_detection/gesture_configuration.h"
+extern char __executable_start;
Torne 2016/12/05 15:19:31 Stick a comment on these explaining that they're d
Robert Sesek 2016/12/05 16:19:18 Are these CXA mangled or should they be extern C?
Tobias Sargeant 2016/12/06 16:48:33 Done.
Tobias Sargeant 2016/12/06 16:48:33 They should be extern "C". (Done.)
+extern char __etext;
+
namespace android_webview {
namespace {
@@ -209,6 +212,8 @@ int AwMainDelegate::RunProcess(
// crash handler on the same thread as the crash handler was initialized.
crash_reporter::AddGpuFingerprintToMicrodumpCrashHandler(
content_client_.gpu_fingerprint());
+ crash_reporter::SetWebViewTextAddrRange((uintptr_t)&__executable_start,
+ (uintptr_t)&__etext);
g_allow_wait_in_ui_thread.Get().reset(
new ScopedAllowWaitForLegacyWebViewApi);

Powered by Google App Engine
This is Rietveld 408576698