Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Issue 255273003: For ARMv6, works around missing instructions. (Closed)

Created:
6 years, 7 months ago by zra
Modified:
6 years, 7 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

For ARMv6, works around missing instructions. mls, mla, umull, smull, etc. are not implemented on all ARMv6's. This change works around them. For mls and mla, we just use two instructions. smull was used to check for overflow in mul, so we have to do that manually. For umlal in the Random intrinsic, we just fall through for now, though in principal it wouldn't be hard to emulate. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=35550

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+300 lines, -59 lines) Patch
M runtime/vm/assembler_arm.h View 1 1 chunk +7 lines, -0 lines 0 comments Download
M runtime/vm/assembler_arm.cc View 1 5 chunks +74 lines, -4 lines 0 comments Download
M runtime/vm/assembler_arm_test.cc View 1 4 chunks +136 lines, -9 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 1 4 chunks +35 lines, -9 lines 0 comments Download
M runtime/vm/intrinsifier_arm.cc View 1 3 chunks +48 lines, -37 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
zra
For https://code.google.com/p/dart/issues/detail?id=18451
6 years, 7 months ago (2014-04-29 20:27:59 UTC) #1
regis
LGTM
6 years, 7 months ago (2014-04-29 22:23:57 UTC) #2
zra
6 years, 7 months ago (2014-04-29 22:31:31 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r35550 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698