Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2552703006:
Remove clearContext() from VRController::contextDestroyed (Closed)
DescriptionRemove clearContext() from VRController::contextDestroyed
Now that ContextLifecycleObserver clears its observing context after calling
contextDestroyed. So there is no need to explicitly call clearContext().
BUG=610176
Committed: https://crrev.com/9c2137797952d207c4b38f3abc3962442f8b9b4a
Cr-Commit-Position: refs/heads/master@{#437821}
Patch Set 1 #
Messages
Total messages: 22 (11 generated)
haraken@chromium.org changed reviewers: + bajones@chromium.org
PTAL
On 2016/12/07 11:42:29, haraken wrote: > PTAL LGTM
The CQ bit was checked by haraken@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by haraken@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by haraken@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by haraken@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481516246867770, "parent_rev":
"2037ed3c228e0b1837eeaefcd739f79ab18c9491", "commit_rev":
"4058396497ab9e827ef0363305ed3111548c1684"}
Message was sent while issue was closed.
Description was changed from ========== Remove clearContext() from VRController::contextDestroyed Now that ContextLifecycleObserver clears its observing context after calling contextDestroyed. So there is no need to explicitly call clearContext(). BUG=610176 ========== to ========== Remove clearContext() from VRController::contextDestroyed Now that ContextLifecycleObserver clears its observing context after calling contextDestroyed. So there is no need to explicitly call clearContext(). BUG=610176 Review-Url: https://codereview.chromium.org/2552703006 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Remove clearContext() from VRController::contextDestroyed Now that ContextLifecycleObserver clears its observing context after calling contextDestroyed. So there is no need to explicitly call clearContext(). BUG=610176 Review-Url: https://codereview.chromium.org/2552703006 ========== to ========== Remove clearContext() from VRController::contextDestroyed Now that ContextLifecycleObserver clears its observing context after calling contextDestroyed. So there is no need to explicitly call clearContext(). BUG=610176 Committed: https://crrev.com/9c2137797952d207c4b38f3abc3962442f8b9b4a Cr-Commit-Position: refs/heads/master@{#437821} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/9c2137797952d207c4b38f3abc3962442f8b9b4a Cr-Commit-Position: refs/heads/master@{#437821} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
