Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 25527004: Move PlatformEvent.cpp/.h to Source/platform/ (Closed)

Created:
7 years, 2 months ago by pilgrim_google
Modified:
7 years, 2 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, darin (slow to review)
Visibility:
Public.

Description

Move PlatformEvent.cpp/.h to Source/platform/ BUG=297477 R=abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158974

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Patch Set 5 : remove PLATFORM_EXPORT macro from entirely-inline class #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -178 lines) Patch
M Source/core/core.gypi View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorInputAgent.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/page/EventHandler.cpp View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
D Source/core/platform/PlatformEvent.h View 1 chunk +0 lines, -142 lines 0 comments Download
D Source/core/platform/PlatformEvent.cpp View 1 chunk +0 lines, -27 lines 0 comments Download
M Source/core/platform/PlatformGestureEvent.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/PlatformKeyboardEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/PlatformMouseEvent.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/PlatformTouchEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/PlatformWheelEvent.h View 1 1 chunk +1 line, -1 line 0 comments Download
A + Source/platform/PlatformEvent.h View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M Source/platform/blink_platform.gypi View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
pilgrim_google
7 years, 2 months ago (2013-10-02 03:02:08 UTC) #1
abarth-chromium
lgtm https://codereview.chromium.org/25527004/diff/1/Source/platform/PlatformEvent.cpp File Source/platform/PlatformEvent.cpp (right): https://codereview.chromium.org/25527004/diff/1/Source/platform/PlatformEvent.cpp#newcode27 Source/platform/PlatformEvent.cpp:27: #include "platform/PlatformEvent.h" I don't think we need PlatformEvent.cpp ...
7 years, 2 months ago (2013-10-02 06:28:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pilgrim@chromium.org/25527004/8001
7 years, 2 months ago (2013-10-02 18:29:49 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_layout for step(s) webkit_lint http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout&number=11119
7 years, 2 months ago (2013-10-03 00:01:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pilgrim@chromium.org/25527004/20001
7 years, 2 months ago (2013-10-03 02:32:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pilgrim@chromium.org/25527004/20001
7 years, 2 months ago (2013-10-03 05:41:35 UTC) #6
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 2 months ago (2013-10-03 10:49:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pilgrim@chromium.org/25527004/38001
7 years, 2 months ago (2013-10-04 02:23:10 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=6764
7 years, 2 months ago (2013-10-04 04:07:54 UTC) #9
pilgrim_google
remove PLATFORM_EXPORT macro from entirely-inline class
7 years, 2 months ago (2013-10-04 21:36:37 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pilgrim@chromium.org/25527004/49001
7 years, 2 months ago (2013-10-04 21:36:59 UTC) #11
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=9060
7 years, 2 months ago (2013-10-05 00:48:58 UTC) #12
pilgrim_google
7 years, 2 months ago (2013-10-05 02:52:24 UTC) #13
Message was sent while issue was closed. 
Committed patchset #5 manually as r158974 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698