Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2552693002: [Merge M-56] Rename canMakeActivePayment to canMakePayment (Closed)

Created:
4 years ago by please use gerrit instead
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

[Merge M-56] Rename canMakeActivePayment to canMakePayment It was decided to rename canMakeActivePayment to canMakePayment: https://github.com/w3c/browser-payment-api/pull/316 Note that this feature is still behind a runtime flag, now named CanMakePayment. BUG=670967 Review-Url: https://codereview.chromium.org/2545523004 Cr-Commit-Position: refs/heads/master@{#436078} (cherry picked from commit e3da0af8a1228f17aebefd2f73518654c8b2ab98) Committed: https://chromium.googlesource.com/chromium/src/+/6163da6f7a6f1308f2552e08b7a0b7cd003dd42f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -870 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestFactory.java View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java View 10 chunks +30 lines, -30 lines 0 comments Download
M chrome/android/java_sources.gni View 2 chunks +5 lines, -5 lines 0 comments Download
D chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestActivePaymentQueryNoCardTest.java View 1 chunk +0 lines, -81 lines 0 comments Download
D chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestActivePaymentQueryTest.java View 1 chunk +0 lines, -86 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCanMakePaymentQueryNoCardTest.java View 6 chunks +11 lines, -11 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCanMakePaymentQueryTest.java View 6 chunks +11 lines, -11 lines 0 comments Download
D chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCcActivePaymentQueryNoCardTest.java View 1 chunk +0 lines, -45 lines 0 comments Download
D chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCcActivePaymentQueryTest.java View 1 chunk +0 lines, -65 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCcCanMakePaymentQueryNoCardTest.java View 2 chunks +9 lines, -8 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCcCanMakePaymentQueryTest.java View 2 chunks +12 lines, -12 lines 0 comments Download
D chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPaymentAppActivePaymentQueryTest.java View 1 chunk +0 lines, -86 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPaymentAppCanMakePaymentQueryTest.java View 6 chunks +15 lines, -15 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java View 3 chunks +4 lines, -4 lines 0 comments Download
D chrome/test/data/android/payments/active_payment_query.js View 1 chunk +0 lines, -28 lines 0 comments Download
D chrome/test/data/android/payments/active_payment_query_bobpay.js View 1 chunk +0 lines, -93 lines 0 comments Download
D chrome/test/data/android/payments/active_payment_query_cc.js View 1 chunk +0 lines, -48 lines 0 comments Download
A + chrome/test/data/android/payments/can_make_payment_query.js View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/test/data/android/payments/can_make_payment_query_bobpay.js View 4 chunks +4 lines, -4 lines 0 comments Download
A + chrome/test/data/android/payments/can_make_payment_query_cc.js View 2 chunks +2 lines, -2 lines 0 comments Download
D chrome/test/data/android/payments/payment_request_active_payment_query_bobpay_test.html View 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/test/data/android/payments/payment_request_active_payment_query_cc_test.html View 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/test/data/android/payments/payment_request_active_payment_query_test.html View 1 chunk +0 lines, -20 lines 0 comments Download
A + chrome/test/data/android/payments/payment_request_can_make_payment_query_bobpay_test.html View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/test/data/android/payments/payment_request_can_make_payment_query_cc_test.html View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/test/data/android/payments/payment_request_can_make_payment_query_test.html View 1 chunk +1 line, -1 line 0 comments Download
M components/payments/payment_request.mojom View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/Source/modules/payments/ActivePaymentTest.cpp View 1 chunk +0 lines, -114 lines 0 comments Download
A + third_party/WebKit/Source/modules/payments/CanMakePaymentTest.cpp View 7 chunks +21 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequest.h View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequest.cpp View 7 chunks +21 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequest.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
please use gerrit instead
4 years ago (2016-12-05 11:13:06 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
6163da6f7a6f1308f2552e08b7a0b7cd003dd42f.

Powered by Google App Engine
This is Rietveld 408576698