Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(781)

Unified Diff: content/public/browser/navigation_controller.h

Issue 2552663002: NavigationController: merge Reload*() to one Reload() with ReloadType (Closed)
Patch Set: [rebase] Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/frame_host/navigation_controller_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/navigation_controller.h
diff --git a/content/public/browser/navigation_controller.h b/content/public/browser/navigation_controller.h
index 3d3975235d74b2d187ef0fb4baa83b1dadfe208d..9c7d8c18d53c409eae905be114a33eeb04e0e61e 100644
--- a/content/public/browser/navigation_controller.h
+++ b/content/public/browser/navigation_controller.h
@@ -17,6 +17,7 @@
#include "build/build_config.h"
#include "content/common/content_export.h"
#include "content/public/browser/global_request_id.h"
+#include "content/public/browser/reload_type.h"
#include "content/public/browser/restore_type.h"
#include "content/public/browser/session_storage_namespace.h"
#include "content/public/browser/site_instance.h"
@@ -349,6 +350,13 @@ class NavigationController {
// the offset is out of bounds.
virtual void GoToOffset(int offset) = 0;
+ // Reloads the current entry under the specified ReloadType.
+ // TODO(toyoshim): Change all callers to use this new Reload(), and remove
+ // old Reload* methods below. One motivation of this change is Reload(bool)
+ // interface is just confusing because in some contexts, the bool could be to
+ // specify bypassing cache. http://crbug.com/670232
+ virtual void Reload(bool check_for_repost, ReloadType reload_type) = 0;
+
// Reloads the current entry. If |check_for_repost| is true and the current
// entry has POST data the user is prompted to see if they really want to
// reload the page. In nearly all cases pass in true. If a transient entry
« no previous file with comments | « content/browser/frame_host/navigation_controller_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698