Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Unified Diff: content/browser/frame_host/navigation_controller_impl.cc

Issue 2552663002: NavigationController: merge Reload*() to one Reload() with ReloadType (Closed)
Patch Set: [rebase] Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_controller_impl.cc
diff --git a/content/browser/frame_host/navigation_controller_impl.cc b/content/browser/frame_host/navigation_controller_impl.cc
index 2e845ae1e705d8515294f56bf88757b1d041fc44..2d90ebb2f9db861d3fd425e46ce60d45039c25a8 100644
--- a/content/browser/frame_host/navigation_controller_impl.cc
+++ b/content/browser/frame_host/navigation_controller_impl.cc
@@ -265,20 +265,20 @@ void NavigationControllerImpl::Restore(
}
void NavigationControllerImpl::Reload(bool check_for_repost) {
- ReloadInternal(check_for_repost, ReloadType::NORMAL);
+ Reload(check_for_repost, ReloadType::NORMAL);
}
void NavigationControllerImpl::ReloadBypassingCache(bool check_for_repost) {
- ReloadInternal(check_for_repost, ReloadType::BYPASSING_CACHE);
+ Reload(check_for_repost, ReloadType::BYPASSING_CACHE);
}
void NavigationControllerImpl::ReloadOriginalRequestURL(bool check_for_repost) {
- ReloadInternal(check_for_repost, ReloadType::ORIGINAL_REQUEST_URL);
+ Reload(check_for_repost, ReloadType::ORIGINAL_REQUEST_URL);
}
void NavigationControllerImpl::ReloadDisableLoFi(bool check_for_repost) {
- ReloadInternal(check_for_repost, ReloadType::DISABLE_LOFI_MODE);
+ Reload(check_for_repost, ReloadType::DISABLE_LOFI_MODE);
}
-void NavigationControllerImpl::ReloadInternal(bool check_for_repost,
- ReloadType reload_type) {
+void NavigationControllerImpl::Reload(bool check_for_repost,
+ ReloadType reload_type) {
if (transient_entry_index_ != -1) {
// If an interstitial is showing, treat a reload as a navigation to the
// transient entry's URL.
@@ -402,7 +402,7 @@ void NavigationControllerImpl::ContinuePendingReload() {
if (pending_reload_ == ReloadType::NONE) {
NOTREACHED();
} else {
- ReloadInternal(false, pending_reload_);
+ Reload(false, pending_reload_);
pending_reload_ = ReloadType::NONE;
}
}
« no previous file with comments | « content/browser/frame_host/navigation_controller_impl.h ('k') | content/public/browser/navigation_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698