Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: content/browser/frame_host/navigation_controller_impl.h

Issue 2552663002: NavigationController: merge Reload*() to one Reload() with ReloadType (Closed)
Patch Set: [rebase] Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/browser_commands.cc ('k') | content/browser/frame_host/navigation_controller_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/navigation_controller_impl.h
diff --git a/content/browser/frame_host/navigation_controller_impl.h b/content/browser/frame_host/navigation_controller_impl.h
index 9b77719a64a55cbfe98ee57c124a02990d285cfe..f7b9144c75e2c4f80cca3fcb785b71401a38a433 100644
--- a/content/browser/frame_host/navigation_controller_impl.h
+++ b/content/browser/frame_host/navigation_controller_impl.h
@@ -83,6 +83,9 @@ class CONTENT_EXPORT NavigationControllerImpl
void ContinuePendingReload() override;
bool IsInitialNavigation() const override;
bool IsInitialBlankNavigation() const override;
+ void Reload(bool check_for_repost, ReloadType reload_type) override;
+ // TODO(toyoshim): Remove following Reload* methods once all callers to use
+ // new Reload() with ReloadType above. http://crbug.com/670232
void Reload(bool check_for_repost) override;
void ReloadBypassingCache(bool check_for_repost) override;
void ReloadOriginalRequestURL(bool check_for_repost) override;
@@ -296,10 +299,6 @@ class CONTENT_EXPORT NavigationControllerImpl
RenderFrameHostImpl* rfh,
const FrameHostMsg_DidCommitProvisionalLoad_Params& params);
- // Helper function for code shared between Reload() and
- // ReloadBypassingCache().
- void ReloadInternal(bool check_for_repost, ReloadType reload_type);
-
// Actually issues the navigation held in pending_entry.
void NavigateToPendingEntry(ReloadType reload_type);
« no previous file with comments | « chrome/browser/ui/browser_commands.cc ('k') | content/browser/frame_host/navigation_controller_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698