Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1379)

Issue 2552613002: Mere "Avoid unchecked casts in UA shadow DOM." to M56 (Closed)

Created:
4 years ago by tkent
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Mere "Avoid unchecked casts in UA shadow DOM." to M56 If we have a way to leak UA shadow DOM to web authors or Chrome extension authors, these unchecked casts would be dangerous. This CL introduces toFooTypeOrDie() helpers, and apply it to UA shadow DOM. BUG=668970 Review-Url: https://codereview.chromium.org/2534873004 Cr-Commit-Position: refs/heads/master@{#434899} (cherry picked from commit 2ce7841faa0fcfb4bff02b808745a9399a1c0603) Committed: https://chromium.googlesource.com/chromium/src/+/0db497a39cbefc87a1c63ebfa6e5b26eda899da7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -44 lines) Patch
M third_party/WebKit/Source/build/scripts/templates/ElementTypeHelpers.h.tmpl View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.h View 1 chunk +21 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLDetailsElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLKeygenElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLOptGroupElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/TextControlElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/BaseButtonInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/ColorInputType.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/FileInputType.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/MultipleFieldsTemporalInputTypeView.cpp View 1 chunk +10 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/RangeInputType.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/shadow/DateTimeEditElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGUseElement.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/Assertions.h View 1 chunk +47 lines, -21 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
tkent
4 years ago (2016-12-05 00:14:11 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0db497a39cbefc87a1c63ebfa6e5b26eda899da7.

Powered by Google App Engine
This is Rietveld 408576698