Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1076)

Unified Diff: ash/public/interfaces/volume.mojom

Issue 2552483002: mash: Have chrome set itself as a controller interface for changing volume (Closed)
Patch Set: comment Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/public/interfaces/volume.mojom
diff --git a/ash/public/interfaces/volume.mojom b/ash/public/interfaces/volume.mojom
index 85bd93928bbbbece6849930d9c3662d92313f4af..3e5b1da7aa581d35c9992816127c617a4bf7b332 100644
--- a/ash/public/interfaces/volume.mojom
+++ b/ash/public/interfaces/volume.mojom
@@ -6,7 +6,10 @@ module ash.mojom;
// Implemented by Chrome and used by ash to request audio volume changes.
// Implemented by Chrome because it's currently the only client of audio dbus
-// interfaces (via CrasAudioHandler); this may be simplified if that changes.
+// interfaces (via CrasAudioHandler).
+// TODO(crbug.com/644336): Flip this pattern, ash should implement the volume
+// control interface or both ash and chrome should directly access the
+// CrasAudioHandler volume control functions.
interface VolumeController {
// Mute the audio volume.
VolumeMute();
« no previous file with comments | « ash/public/interfaces/accelerator_controller.mojom ('k') | chrome/browser/chrome_content_browser_manifest_overlay.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698