Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: ash/public/interfaces/accelerator_controller.mojom

Issue 2552483002: mash: Have chrome set itself as a controller interface for changing volume (Closed)
Patch Set: comment Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/public/interfaces/BUILD.gn ('k') | ash/public/interfaces/volume.mojom » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/public/interfaces/accelerator_controller.mojom
diff --git a/ash/public/interfaces/volume.mojom b/ash/public/interfaces/accelerator_controller.mojom
similarity index 30%
copy from ash/public/interfaces/volume.mojom
copy to ash/public/interfaces/accelerator_controller.mojom
index 85bd93928bbbbece6849930d9c3662d92313f4af..0fe3475a6a1ea33d70138a7856fee413a740b54d 100644
--- a/ash/public/interfaces/volume.mojom
+++ b/ash/public/interfaces/accelerator_controller.mojom
@@ -4,14 +4,13 @@
module ash.mojom;
-// Implemented by Chrome and used by ash to request audio volume changes.
-// Implemented by Chrome because it's currently the only client of audio dbus
-// interfaces (via CrasAudioHandler); this may be simplified if that changes.
-interface VolumeController {
- // Mute the audio volume.
- VolumeMute();
- // Decrease the audio volume.
- VolumeDown();
- // Increase the audio volume.
- VolumeUp();
+import "ash/public/interfaces/volume.mojom";
+
+// Implemented by ash to delegate parts of keyboard accelerator handling back
+// to chrome.
+interface AcceleratorController {
+ // Sets the volume controller interface. This lives in chrome because chrome
+ // owns the D-Bus CrasAudioHandler implementation. Also the accessibility
+ // manager in chrome needs to know about volume changes.
+ SetVolumeController(VolumeController controller);
};
« no previous file with comments | « ash/public/interfaces/BUILD.gn ('k') | ash/public/interfaces/volume.mojom » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698