Add more ResourceLoaderTests

net/url_request/url_request_test_job.h

Index: net/url_request/url_request_test_job.h
diff --git a/net/url_request/url_request_test_job.h b/net/url_request/url_request_test_job.h
index 0f327236848a4dec9e0d2ccd2b675368968ac3c6..7685ab16246104c04d6e256fb7056272edde196c 100644
--- a/net/url_request/url_request_test_job.h
+++ b/net/url_request/url_request_test_job.h
@@ -63,13 +63,28 @@ class NET_EXPORT_PRIVATE URLRequestTestJob : public URLRequestJob {
 
   // The canned URLs this handler will respond to without having been
   // explicitly initialized with response headers and data.
-  // FIXME(brettw): we should probably also have a redirect one
+
+  // URL that, by default, automatically advances through each state.  Reads
+  // complete synchronously.

[Randy Smith (Not in Mondays), 2016/12/08 22:15:09]

nit, suggestion: Name the methods s.t. there's a gesture at their functionality?

ETA: If the answer is "Don't want to change all the call sites", I'm fine with
that.

[mmenke, 2016/12/08 22:46:37]

Yea, I'm going with "You have a point, but I don't want to change all callsites"
(Though, admittedly, most are in browser/loader).  I do think this class is
worth cleaning up, and maybe even moving into browser/loader to discourage more
general use, since it's weird, but think that's for another day.

   static GURL test_url_1();
+
+  // URLs that, by default, must be manually advanced through each state.
   static GURL test_url_2();
   static GURL test_url_3();
   static GURL test_url_4();
+
+  // URL that, by default, automatically advances through each state.  Reads
+  // complete asynchronously. Has same response body as test_url_1(), which is
+  // (test_data_1()).
+  static GURL test_url_auto_advance_async_reads_1();
+
+  // URL that fails with ERR_INVALID_URL.
   static GURL test_url_error();
+
+  // Redirects to test_url_1().
   static GURL test_url_redirect_to_url_1();
+
+  // Redirects to test_url_2().
   static GURL test_url_redirect_to_url_2();
 
   // The data that corresponds to each of the URLs above
@@ -178,6 +193,8 @@ class NET_EXPORT_PRIVATE URLRequestTestJob : public URLRequestJob {
   // Original size in bytes of the response headers before decoding.
   int response_headers_length_;
 
+  bool async_reads_;
+
   base::WeakPtrFactory<URLRequestTestJob> weak_factory_;
 };