Add more ResourceLoaderTests

net/url_request/url_request_test_job.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_URL_REQUEST_URL_REQUEST_TEST_JOB_H_
 #define NET_URL_REQUEST_URL_REQUEST_TEST_JOB_H_
 
 #include <string>
 
 #include "base/memory/weak_ptr.h"
@@ skipping 45 matching lines @@
   URLRequestTestJob(URLRequest* request,
                     NetworkDelegate* network_delegate,
                     const std::string& response_headers,
                     const std::string& response_data,
                     bool auto_advance);
 
   ~URLRequestTestJob() override;
 
   // The canned URLs this handler will respond to without having been
   // explicitly initialized with response headers and data.
-  // FIXME(brettw): we should probably also have a redirect one
+
+  // URL that, by default, automatically advances through each state.  Reads
+  // complete synchronously.

[Randy Smith (Not in Mondays), 2016/12/08 22:15:09]

nit, suggestion: Name the methods s.t. there's a gesture at their functionality?

ETA: If the answer is "Don't want to change all the call sites", I'm fine with
that.

[mmenke, 2016/12/08 22:46:37]

Yea, I'm going with "You have a point, but I don't want to change all callsites"
(Though, admittedly, most are in browser/loader).  I do think this class is
worth cleaning up, and maybe even moving into browser/loader to discourage more
general use, since it's weird, but think that's for another day.

   static GURL test_url_1();
+
+  // URLs that, by default, must be manually advanced through each state.
   static GURL test_url_2();
   static GURL test_url_3();
   static GURL test_url_4();
+
+  // URL that, by default, automatically advances through each state.  Reads
+  // complete asynchronously. Has same response body as test_url_1(), which is
+  // (test_data_1()).
+  static GURL test_url_auto_advance_async_reads_1();
+
+  // URL that fails with ERR_INVALID_URL.
   static GURL test_url_error();
+
+  // Redirects to test_url_1().
   static GURL test_url_redirect_to_url_1();
+
+  // Redirects to test_url_2().
   static GURL test_url_redirect_to_url_2();
 
   // The data that corresponds to each of the URLs above
   static std::string test_data_1();
   static std::string test_data_2();
   static std::string test_data_3();
   static std::string test_data_4();
 
   // The headers that correspond to each of the URLs above
   static std::string test_headers();
@@ skipping 88 matching lines @@
   LoadTimingInfo load_timing_info_;
 
  private:
   // The headers the job should return, will be set in Start() if not provided
   // in the explicit ctor.
   scoped_refptr<HttpResponseHeaders> response_headers_;
 
   // Original size in bytes of the response headers before decoding.
   int response_headers_length_;
 
+  bool async_reads_;
+
   base::WeakPtrFactory<URLRequestTestJob> weak_factory_;
 };
 
 }  // namespace net
 
 #endif  // NET_URL_REQUEST_URL_REQUEST_TEST_JOB_H_