Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Issue 2552383003: Change getStyleChangeType() == NeedsReattachStyleChange to call needsAttach() instead (Closed)

Created:
4 years ago by nainar
Modified:
4 years ago
Reviewers:
sashab, Bugs Nash
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change getStyleChangeType() == NeedsReattachStyleChange to call needsAttach() instead needsAttach() checks that getStyleChangeType is NeedsReattachStyleChange the functions changed here have been changed to call the function instead of checking this directly. BUG=595137 Committed: https://crrev.com/e67ef441d061fc7714cd589a90c98d33af77350b Cr-Commit-Position: refs/heads/master@{#436846}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/core/dom/Element.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Node.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
nainar
PTAL? Thanks!
4 years ago (2016-12-06 23:21:14 UTC) #3
Bugs Nash
lgtm
4 years ago (2016-12-07 02:04:00 UTC) #7
nainar
@sashab for OWNERS
4 years ago (2016-12-07 02:30:56 UTC) #9
sashab
nice, happy to see this change! lgtm
4 years ago (2016-12-07 02:32:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2552383003/1
4 years ago (2016-12-07 02:35:47 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-07 02:44:12 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-07 02:48:50 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e67ef441d061fc7714cd589a90c98d33af77350b
Cr-Commit-Position: refs/heads/master@{#436846}

Powered by Google App Engine
This is Rietveld 408576698