Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(962)

Side by Side Diff: third_party/WebKit/Source/core/dom/Element.cpp

Issue 2552383003: Change getStyleChangeType() == NeedsReattachStyleChange to call needsAttach() instead (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/Node.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Peter Kelly (pmk@post.com) 4 * (C) 2001 Peter Kelly (pmk@post.com)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * (C) 2007 David Smith (catfish.man@gmail.com) 6 * (C) 2007 David Smith (catfish.man@gmail.com)
7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. 7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc.
8 * All rights reserved. 8 * All rights reserved.
9 * (C) 2007 Eric Seidel (eric@webkit.org) 9 * (C) 2007 Eric Seidel (eric@webkit.org)
10 * 10 *
(...skipping 1646 matching lines...) Expand 10 before | Expand all | Expand 10 after
1657 1657
1658 if (document().frame()) 1658 if (document().frame())
1659 document().frame()->eventHandler().elementRemoved(this); 1659 document().frame()->eventHandler().elementRemoved(this);
1660 } 1660 }
1661 1661
1662 void Element::attachLayoutTree(const AttachContext& context) { 1662 void Element::attachLayoutTree(const AttachContext& context) {
1663 DCHECK(document().inStyleRecalc()); 1663 DCHECK(document().inStyleRecalc());
1664 1664
1665 // We've already been through detach when doing an attach, but we might 1665 // We've already been through detach when doing an attach, but we might
1666 // need to clear any state that's been added since then. 1666 // need to clear any state that's been added since then.
1667 if (hasRareData() && getStyleChangeType() == NeedsReattachStyleChange) { 1667 if (hasRareData() && needsAttach()) {
1668 ElementRareData* data = elementRareData(); 1668 ElementRareData* data = elementRareData();
1669 data->clearComputedStyle(); 1669 data->clearComputedStyle();
1670 } 1670 }
1671 1671
1672 if (!isActiveSlotOrActiveInsertionPoint()) 1672 if (!isActiveSlotOrActiveInsertionPoint())
1673 LayoutTreeBuilderForElement(*this, context.resolvedStyle) 1673 LayoutTreeBuilderForElement(*this, context.resolvedStyle)
1674 .createLayoutObjectIfNeeded(); 1674 .createLayoutObjectIfNeeded();
1675 1675
1676 addCallbackSelectors(); 1676 addCallbackSelectors();
1677 1677
(...skipping 2413 matching lines...) Expand 10 before | Expand all | Expand 10 after
4091 } 4091 }
4092 4092
4093 DEFINE_TRACE_WRAPPERS(Element) { 4093 DEFINE_TRACE_WRAPPERS(Element) {
4094 if (hasRareData()) { 4094 if (hasRareData()) {
4095 visitor->traceWrappers(elementRareData()); 4095 visitor->traceWrappers(elementRareData());
4096 } 4096 }
4097 ContainerNode::traceWrappers(visitor); 4097 ContainerNode::traceWrappers(visitor);
4098 } 4098 }
4099 4099
4100 } // namespace blink 4100 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/Node.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698