Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Unified Diff: chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc

Issue 2552263002: Pass InteractionStats by value (Closed)
Patch Set: ={} Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc
diff --git a/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc b/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc
index 7d43dffa7137008ce1500aec232eb0cad8dab505..d9e9610022a48b31f1c4ed414b21372d0f25cd46 100644
--- a/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc
+++ b/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc
@@ -353,11 +353,11 @@ TEST_F(ManagePasswordsUIControllerTest, PasswordSubmittedBubbleSuppressed) {
CreateSmartBubbleFieldTrial();
std::unique_ptr<password_manager::PasswordFormManager> test_form_manager(
CreateFormManager());
- password_manager::InteractionsStats stats;
- stats.origin_domain = test_local_form().origin.GetOrigin();
- stats.username_value = test_local_form().username_value;
- stats.dismissal_count = kGreatDissmisalCount;
- fetcher().set_stats({&stats});
+ std::vector<password_manager::InteractionsStats> stats(1);
+ stats[0].origin_domain = test_local_form().origin.GetOrigin();
+ stats[0].username_value = test_local_form().username_value;
+ stats[0].dismissal_count = kGreatDissmisalCount;
+ fetcher().set_stats(stats);
test_form_manager->ProvisionallySave(
test_local_form(),
password_manager::PasswordFormManager::IGNORE_OTHER_POSSIBLE_USERNAMES);
@@ -367,7 +367,7 @@ TEST_F(ManagePasswordsUIControllerTest, PasswordSubmittedBubbleSuppressed) {
controller()->GetState());
EXPECT_FALSE(controller()->opened_bubble());
ASSERT_TRUE(controller()->GetCurrentInteractionStats());
- EXPECT_EQ(stats, *controller()->GetCurrentInteractionStats());
+ EXPECT_EQ(stats[0], *controller()->GetCurrentInteractionStats());
ExpectIconStateIs(password_manager::ui::PENDING_PASSWORD_STATE);
variations::testing::ClearAllVariationParams();
@@ -377,11 +377,11 @@ TEST_F(ManagePasswordsUIControllerTest, PasswordSubmittedBubbleNotSuppressed) {
CreateSmartBubbleFieldTrial();
std::unique_ptr<password_manager::PasswordFormManager> test_form_manager(
CreateFormManager());
- password_manager::InteractionsStats stats;
- stats.origin_domain = test_local_form().origin.GetOrigin();
- stats.username_value = base::ASCIIToUTF16("not my username");
- stats.dismissal_count = kGreatDissmisalCount;
- fetcher().set_stats({&stats});
+ std::vector<password_manager::InteractionsStats> stats(1);
+ stats[0].origin_domain = test_local_form().origin.GetOrigin();
+ stats[0].username_value = base::ASCIIToUTF16("not my username");
+ stats[0].dismissal_count = kGreatDissmisalCount;
+ fetcher().set_stats(stats);
test_form_manager->ProvisionallySave(
test_local_form(),
password_manager::PasswordFormManager::IGNORE_OTHER_POSSIBLE_USERNAMES);

Powered by Google App Engine
This is Rietveld 408576698