Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2552213002: Remove explicit singletonness of ArcBridgeService part 1. (Closed)

Created:
4 years ago by hidehiko
Modified:
4 years ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, yusukes+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove explicit singletonness of ArcBridgeService part 1. This CL removes ArcBridgeService::Get() invocation from ArcBridgeHostImpl. BUG=657687 BUG=b/31079732 TEST=Ran on test device. Ran bots. Committed: https://crrev.com/01319c4e330d99d28eb1308863e7cdd6badc6bf3 Cr-Commit-Position: refs/heads/master@{#437191}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment #

Patch Set 3 : git cl format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -36 lines) Patch
M components/arc/arc_bridge_host_impl.h View 3 chunks +7 lines, -1 line 0 comments Download
M components/arc/arc_bridge_host_impl.cc View 1 2 2 chunks +30 lines, -29 lines 0 comments Download
M components/arc/arc_bridge_service_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/arc/arc_session.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/arc/arc_session.cc View 1 2 5 chunks +14 lines, -5 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
hidehiko
PTAL. Note: this is also preparation to let ArcSessionManager manage ArcSession, instead of ArcBridgeService.
4 years ago (2016-12-06 07:46:50 UTC) #4
Luis Héctor Chávez
https://codereview.chromium.org/2552213002/diff/1/components/arc/arc_session.cc File components/arc/arc_session.cc (right): https://codereview.chromium.org/2552213002/diff/1/components/arc/arc_session.cc#newcode242 components/arc/arc_session.cc:242: ArcBridgeService* const arc_bridge_service_; Please mention who owns this pointer.
4 years ago (2016-12-06 18:48:33 UTC) #7
hidehiko
Thank you for review. PTAL. https://codereview.chromium.org/2552213002/diff/1/components/arc/arc_session.cc File components/arc/arc_session.cc (right): https://codereview.chromium.org/2552213002/diff/1/components/arc/arc_session.cc#newcode242 components/arc/arc_session.cc:242: ArcBridgeService* const arc_bridge_service_; On ...
4 years ago (2016-12-06 18:54:36 UTC) #10
Luis Héctor Chávez
lgtm
4 years ago (2016-12-06 19:18:17 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2552213002/40001
4 years ago (2016-12-08 05:25:15 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-08 06:00:52 UTC) #17
commit-bot: I haz the power
4 years ago (2016-12-08 06:04:32 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/01319c4e330d99d28eb1308863e7cdd6badc6bf3
Cr-Commit-Position: refs/heads/master@{#437191}

Powered by Google App Engine
This is Rietveld 408576698