Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Unified Diff: components/arc/arc_bridge_host_impl.cc

Issue 2552213002: Remove explicit singletonness of ArcBridgeService part 1. (Closed)
Patch Set: git cl format Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/arc/arc_bridge_host_impl.h ('k') | components/arc/arc_bridge_service_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/arc/arc_bridge_host_impl.cc
diff --git a/components/arc/arc_bridge_host_impl.cc b/components/arc/arc_bridge_host_impl.cc
index 1fc93b50b4c56ba12637286fda5f5d915c8ef9e9..b22068e5d4e208115c75f759d8d0fa7cee87658e 100644
--- a/components/arc/arc_bridge_host_impl.cc
+++ b/components/arc/arc_bridge_host_impl.cc
@@ -67,8 +67,12 @@ class MojoChannelImpl : public ArcBridgeHostImpl::MojoChannel {
} // namespace
-ArcBridgeHostImpl::ArcBridgeHostImpl(mojom::ArcBridgeInstancePtr instance)
- : binding_(this), instance_(std::move(instance)) {
+ArcBridgeHostImpl::ArcBridgeHostImpl(ArcBridgeService* arc_bridge_service,
+ mojom::ArcBridgeInstancePtr instance)
+ : arc_bridge_service_(arc_bridge_service),
+ binding_(this),
+ instance_(std::move(instance)) {
+ DCHECK(arc_bridge_service_);
DCHECK(instance_.is_bound());
instance_.set_connection_error_handler(
base::Bind(&ArcBridgeHostImpl::OnClosed, base::Unretained(this)));
@@ -80,129 +84,126 @@ ArcBridgeHostImpl::~ArcBridgeHostImpl() {
}
void ArcBridgeHostImpl::OnAppInstanceReady(mojom::AppInstancePtr app_ptr) {
- OnInstanceReady(ArcBridgeService::Get()->app(), std::move(app_ptr));
+ OnInstanceReady(arc_bridge_service_->app(), std::move(app_ptr));
}
void ArcBridgeHostImpl::OnAudioInstanceReady(
mojom::AudioInstancePtr audio_ptr) {
- OnInstanceReady(ArcBridgeService::Get()->audio(), std::move(audio_ptr));
+ OnInstanceReady(arc_bridge_service_->audio(), std::move(audio_ptr));
}
void ArcBridgeHostImpl::OnAuthInstanceReady(mojom::AuthInstancePtr auth_ptr) {
- OnInstanceReady(ArcBridgeService::Get()->auth(), std::move(auth_ptr));
+ OnInstanceReady(arc_bridge_service_->auth(), std::move(auth_ptr));
}
void ArcBridgeHostImpl::OnBluetoothInstanceReady(
mojom::BluetoothInstancePtr bluetooth_ptr) {
- OnInstanceReady(ArcBridgeService::Get()->bluetooth(),
- std::move(bluetooth_ptr));
+ OnInstanceReady(arc_bridge_service_->bluetooth(), std::move(bluetooth_ptr));
}
void ArcBridgeHostImpl::OnBootPhaseMonitorInstanceReady(
mojom::BootPhaseMonitorInstancePtr boot_phase_monitor_ptr) {
- OnInstanceReady(ArcBridgeService::Get()->boot_phase_monitor(),
+ OnInstanceReady(arc_bridge_service_->boot_phase_monitor(),
std::move(boot_phase_monitor_ptr));
}
void ArcBridgeHostImpl::OnClipboardInstanceReady(
mojom::ClipboardInstancePtr clipboard_ptr) {
- OnInstanceReady(ArcBridgeService::Get()->clipboard(),
- std::move(clipboard_ptr));
+ OnInstanceReady(arc_bridge_service_->clipboard(), std::move(clipboard_ptr));
}
void ArcBridgeHostImpl::OnCrashCollectorInstanceReady(
mojom::CrashCollectorInstancePtr crash_collector_ptr) {
- OnInstanceReady(ArcBridgeService::Get()->crash_collector(),
+ OnInstanceReady(arc_bridge_service_->crash_collector(),
std::move(crash_collector_ptr));
}
void ArcBridgeHostImpl::OnEnterpriseReportingInstanceReady(
mojom::EnterpriseReportingInstancePtr enterprise_reporting_ptr) {
- OnInstanceReady(ArcBridgeService::Get()->enterprise_reporting(),
+ OnInstanceReady(arc_bridge_service_->enterprise_reporting(),
std::move(enterprise_reporting_ptr));
}
void ArcBridgeHostImpl::OnFileSystemInstanceReady(
mojom::FileSystemInstancePtr file_system_ptr) {
- OnInstanceReady(ArcBridgeService::Get()->file_system(),
+ OnInstanceReady(arc_bridge_service_->file_system(),
std::move(file_system_ptr));
}
void ArcBridgeHostImpl::OnImeInstanceReady(mojom::ImeInstancePtr ime_ptr) {
- OnInstanceReady(ArcBridgeService::Get()->ime(), std::move(ime_ptr));
+ OnInstanceReady(arc_bridge_service_->ime(), std::move(ime_ptr));
}
void ArcBridgeHostImpl::OnIntentHelperInstanceReady(
mojom::IntentHelperInstancePtr intent_helper_ptr) {
- OnInstanceReady(ArcBridgeService::Get()->intent_helper(),
+ OnInstanceReady(arc_bridge_service_->intent_helper(),
std::move(intent_helper_ptr));
}
void ArcBridgeHostImpl::OnKioskInstanceReady(
mojom::KioskInstancePtr kiosk_ptr) {
- OnInstanceReady(ArcBridgeService::Get()->kiosk(), std::move(kiosk_ptr));
+ OnInstanceReady(arc_bridge_service_->kiosk(), std::move(kiosk_ptr));
}
void ArcBridgeHostImpl::OnMetricsInstanceReady(
mojom::MetricsInstancePtr metrics_ptr) {
- OnInstanceReady(ArcBridgeService::Get()->metrics(), std::move(metrics_ptr));
+ OnInstanceReady(arc_bridge_service_->metrics(), std::move(metrics_ptr));
}
void ArcBridgeHostImpl::OnNetInstanceReady(mojom::NetInstancePtr net_ptr) {
- OnInstanceReady(ArcBridgeService::Get()->net(), std::move(net_ptr));
+ OnInstanceReady(arc_bridge_service_->net(), std::move(net_ptr));
}
void ArcBridgeHostImpl::OnNotificationsInstanceReady(
mojom::NotificationsInstancePtr notifications_ptr) {
- OnInstanceReady(ArcBridgeService::Get()->notifications(),
+ OnInstanceReady(arc_bridge_service_->notifications(),
std::move(notifications_ptr));
}
void ArcBridgeHostImpl::OnObbMounterInstanceReady(
mojom::ObbMounterInstancePtr obb_mounter_ptr) {
- OnInstanceReady(ArcBridgeService::Get()->obb_mounter(),
+ OnInstanceReady(arc_bridge_service_->obb_mounter(),
std::move(obb_mounter_ptr));
}
void ArcBridgeHostImpl::OnPolicyInstanceReady(
mojom::PolicyInstancePtr policy_ptr) {
- OnInstanceReady(ArcBridgeService::Get()->policy(), std::move(policy_ptr));
+ OnInstanceReady(arc_bridge_service_->policy(), std::move(policy_ptr));
}
void ArcBridgeHostImpl::OnPowerInstanceReady(
mojom::PowerInstancePtr power_ptr) {
- OnInstanceReady(ArcBridgeService::Get()->power(), std::move(power_ptr));
+ OnInstanceReady(arc_bridge_service_->power(), std::move(power_ptr));
}
void ArcBridgeHostImpl::OnPrintInstanceReady(
mojom::PrintInstancePtr print_ptr) {
- OnInstanceReady(ArcBridgeService::Get()->print(), std::move(print_ptr));
+ OnInstanceReady(arc_bridge_service_->print(), std::move(print_ptr));
}
void ArcBridgeHostImpl::OnProcessInstanceReady(
mojom::ProcessInstancePtr process_ptr) {
- OnInstanceReady(ArcBridgeService::Get()->process(), std::move(process_ptr));
+ OnInstanceReady(arc_bridge_service_->process(), std::move(process_ptr));
}
void ArcBridgeHostImpl::OnStorageManagerInstanceReady(
mojom::StorageManagerInstancePtr storage_manager_ptr) {
- OnInstanceReady(ArcBridgeService::Get()->storage_manager(),
+ OnInstanceReady(arc_bridge_service_->storage_manager(),
std::move(storage_manager_ptr));
}
void ArcBridgeHostImpl::OnTtsInstanceReady(mojom::TtsInstancePtr tts_ptr) {
- OnInstanceReady(ArcBridgeService::Get()->tts(), std::move(tts_ptr));
+ OnInstanceReady(arc_bridge_service_->tts(), std::move(tts_ptr));
}
void ArcBridgeHostImpl::OnVideoInstanceReady(
mojom::VideoInstancePtr video_ptr) {
- OnInstanceReady(ArcBridgeService::Get()->video(), std::move(video_ptr));
+ OnInstanceReady(arc_bridge_service_->video(), std::move(video_ptr));
}
void ArcBridgeHostImpl::OnWallpaperInstanceReady(
mojom::WallpaperInstancePtr wallpaper_ptr) {
- OnInstanceReady(ArcBridgeService::Get()->wallpaper(),
- std::move(wallpaper_ptr));
+ OnInstanceReady(arc_bridge_service_->wallpaper(), std::move(wallpaper_ptr));
}
void ArcBridgeHostImpl::OnClosed() {
« no previous file with comments | « components/arc/arc_bridge_host_impl.h ('k') | components/arc/arc_bridge_service_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698