Enable toggling of new accessibility modes in chrome://accessibility

Enable toggling of new accessibility modes in chrome://accessibility

Replaces links that toggled a single accessibility mode with a set of
checkboxes representing more fine-grained control over accessibility
support.

Adds some more help text to the UI to explain to users what this is for.

There's more to be done but I don't want to completely overhaul the UI in
this change, I'd like to just make a good incremental step and most
importantly add support for all of the possible accessibility modes.

Depends on: https://codereview.chromium.org/2558933002/

BUG=672205
Committed: https://crrev.com/5adc955230fdddec66eb327d8cdbe5004a3c34c3
Cr-Commit-Position: refs/heads/master@{#438606}

[dmazzoni, 2016-12-07 20:53:31]

dmazzoni@chromium.org changed reviewers:
+ aboxhall@chromium.org

[aboxhall, 2016-12-12 20:34:46]

https://codereview.chromium.org/2552203005/diff/1/content/browser/accessibili...
File content/browser/accessibility/accessibility_ui.cc (right):

https://codereview.chromium.org/2552203005/diff/1/content/browser/accessibili...
content/browser/accessibility/accessibility_ui.cc:215: bool value;
how about s/value/enabled/ ?

https://codereview.chromium.org/2552203005/diff/1/content/browser/accessibili...
content/browser/accessibility/accessibility_ui.cc:243: if (value == true &&
then you can s/== true// here and s/value == false/!enabled/ below

https://codereview.chromium.org/2552203005/diff/1/content/browser/accessibili...
content/browser/accessibility/accessibility_ui.cc:250: // Similarly if you
disable web accessibility we should remove all
Is that true? Could they not stick around to be "remembered" for when you turn
WebContentsAccessibility back on?

https://codereview.chromium.org/2552203005/diff/1/content/browser/resources/a...
File content/browser/resources/accessibility/accessibility.html (right):

https://codereview.chromium.org/2552203005/diff/1/content/browser/resources/a...
content/browser/resources/accessibility/accessibility.html:114: automatically
on-demand.  Changes to this page only take effect
Oh? That's different from before...

[dmazzoni, 2016-12-13 00:30:15]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[dmazzoni, 2016-12-13 00:30:50]

https://codereview.chromium.org/2552203005/diff/1/content/browser/accessibili...
File content/browser/accessibility/accessibility_ui.cc (right):

https://codereview.chromium.org/2552203005/diff/1/content/browser/accessibili...
content/browser/accessibility/accessibility_ui.cc:215: bool value;
On 2016/12/12 20:34:45, aboxhall wrote:
> how about s/value/enabled/ ?

Done.

https://codereview.chromium.org/2552203005/diff/1/content/browser/accessibili...
content/browser/accessibility/accessibility_ui.cc:243: if (value == true &&
On 2016/12/12 20:34:45, aboxhall wrote:
> then you can s/== true// here and s/value == false/!enabled/ below

Done.

https://codereview.chromium.org/2552203005/diff/1/content/browser/accessibili...
content/browser/accessibility/accessibility_ui.cc:250: // Similarly if you
disable web accessibility we should remove all
On 2016/12/12 20:34:45, aboxhall wrote:
> Is that true? Could they not stick around to be "remembered" for when you turn
> WebContentsAccessibility back on?

OK, how about this: I modified the code to show them as
disabled when they're not applicable. Is that better?

https://codereview.chromium.org/2552203005/diff/1/content/browser/resources/a...
File content/browser/resources/accessibility/accessibility.html (right):

https://codereview.chromium.org/2552203005/diff/1/content/browser/resources/a...
content/browser/resources/accessibility/accessibility.html:114: automatically
on-demand.  Changes to this page only take effect
On 2016/12/12 20:34:45, aboxhall wrote:
> Oh? That's different from before...

No, this is unchanged...we don't remember any changes you make
to this page currently, do we?

[commit-bot: I haz the power, 2016-12-13 00:31:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aboxhall, 2016-12-13 01:15:56]

lgtm

https://codereview.chromium.org/2552203005/diff/1/content/browser/resources/a...
File content/browser/resources/accessibility/accessibility.html (right):

https://codereview.chromium.org/2552203005/diff/1/content/browser/resources/a...
content/browser/resources/accessibility/accessibility.html:114: automatically
on-demand.  Changes to this page only take effect
On 2016/12/13 00:30:50, dmazzoni wrote:
> On 2016/12/12 20:34:45, aboxhall wrote:
> > Oh? That's different from before...
> 
> No, this is unchanged...we don't remember any changes you make
> to this page currently, do we?

Ah I misread! Sorry.

[commit-bot: I haz the power, 2016-12-13 02:26:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 02:26:23]

Dry run: This issue passed the CQ dry run.

[dmazzoni, 2016-12-14 19:10:48]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2016-12-14 19:10:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
aboxhall@chromium.org
Link to the patchset: https://codereview.chromium.org/2552203005/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2016-12-14 19:11:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 20:24:29]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481742648288260,
"parent_rev": "16e6e722366e49e39ee21d690e8020779ec02cb9", "commit_rev":
"d2cbdeb947886bc6f9162e1e317f325001294032"}

[commit-bot: I haz the power, 2016-12-14 20:25:03]

Description was changed from

==========
Enable toggling of new accessibility modes in chrome://accessibility

Replaces links that toggled a single accessibility mode with a set of
checkboxes representing more fine-grained control over accessibility
support.

Adds some more help text to the UI to explain to users what this is for.

There's more to be done but I don't want to completely overhaul the UI in
this change, I'd like to just make a good incremental step and most
importantly add support for all of the possible accessibility modes.

Depends on: https://codereview.chromium.org/2558933002/

BUG=672205
==========

to

==========
Enable toggling of new accessibility modes in chrome://accessibility

Replaces links that toggled a single accessibility mode with a set of
checkboxes representing more fine-grained control over accessibility
support.

Adds some more help text to the UI to explain to users what this is for.

There's more to be done but I don't want to completely overhaul the UI in
this change, I'd like to just make a good incremental step and most
importantly add support for all of the possible accessibility modes.

Depends on: https://codereview.chromium.org/2558933002/

BUG=672205

Review-Url: https://codereview.chromium.org/2552203005
==========

[commit-bot: I haz the power, 2016-12-14 20:25:04]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-14 20:27:43]

Description was changed from

==========
Enable toggling of new accessibility modes in chrome://accessibility

Replaces links that toggled a single accessibility mode with a set of
checkboxes representing more fine-grained control over accessibility
support.

Adds some more help text to the UI to explain to users what this is for.

There's more to be done but I don't want to completely overhaul the UI in
this change, I'd like to just make a good incremental step and most
importantly add support for all of the possible accessibility modes.

Depends on: https://codereview.chromium.org/2558933002/

BUG=672205

Review-Url: https://codereview.chromium.org/2552203005
==========

to

==========
Enable toggling of new accessibility modes in chrome://accessibility

Replaces links that toggled a single accessibility mode with a set of
checkboxes representing more fine-grained control over accessibility
support.

Adds some more help text to the UI to explain to users what this is for.

There's more to be done but I don't want to completely overhaul the UI in
this change, I'd like to just make a good incremental step and most
importantly add support for all of the possible accessibility modes.

Depends on: https://codereview.chromium.org/2558933002/

BUG=672205

Committed: https://crrev.com/5adc955230fdddec66eb327d8cdbe5004a3c34c3
Cr-Commit-Position: refs/heads/master@{#438606}
==========

[commit-bot: I haz the power, 2016-12-14 20:27:44]

Patchset 4 (id:??) landed as
https://crrev.com/5adc955230fdddec66eb327d8cdbe5004a3c34c3
Cr-Commit-Position: refs/heads/master@{#438606}