Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2552183002: Do not show "Just a sec" page if arc-loading page is shown. (Closed)

Created:
4 years ago by hidehiko
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Do not show "Just a sec" page if arc-loading page is shown. The "Just a sec" page looks redundant if we already show "This may take up to a minute or so..." loading page, from users' perspective. Then, skip to show it. BUG=670606 BUG=b/33163416 TEST=Ran bots. TEST=Manually run opt-in flow. Accept ToS, and made sure no "Just a sec" page before "SIGN IN" page. TEST=Manually run opt-in flow. Accept ToS. While "SIGN IN" is shown, log-out from ChromeOS account. Re-login. Then "Just a sec" is shown shortly just before "SIGN IN" page. TEST=Manually run opt-in flow. Accept ToS. While "SIGN IN" is shown, disable network. Click "SIGN IN" and show error page. Re-establish the network. Click "TRY AGAIN" and made sure "Just a sec" is shown shortly just before "SIGN IN" page is re-shown. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2545793003 Cr-Commit-Position: refs/heads/master@{#436155} (cherry picked from commit a1972e35f5d748015b9d9df96cfb3098c450bf36) Committed: https://chromium.googlesource.com/chromium/src/+/6e01c41ab191fd19a374804af87ab24eac6b8a49

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M chrome/browser/resources/chromeos/arc_support/background.js View 1 chunk +9 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
hidehiko
4 years ago (2016-12-06 05:18:25 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6e01c41ab191fd19a374804af87ab24eac6b8a49.

Powered by Google App Engine
This is Rietveld 408576698