Chromium Code Reviews
DescriptionDo not show "Just a sec" page if arc-loading page is shown.
The "Just a sec" page looks redundant if we already show
"This may take up to a minute or so..." loading page,
from users' perspective.
Then, skip to show it.
BUG=670606
BUG=b/33163416
TEST=Ran bots.
TEST=Manually run opt-in flow.
Accept ToS, and made sure no "Just a sec" page before "SIGN IN" page.
TEST=Manually run opt-in flow.
Accept ToS. While "SIGN IN" is shown, log-out from ChromeOS account.
Re-login. Then "Just a sec" is shown shortly just before "SIGN IN" page.
TEST=Manually run opt-in flow.
Accept ToS. While "SIGN IN" is shown, disable network.
Click "SIGN IN" and show error page. Re-establish the network.
Click "TRY AGAIN" and made sure "Just a sec" is shown shortly just before
"SIGN IN" page is re-shown.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2545793003
Cr-Commit-Position: refs/heads/master@{#436155}
(cherry picked from commit a1972e35f5d748015b9d9df96cfb3098c450bf36)
Committed: https://chromium.googlesource.com/chromium/src/+/6e01c41ab191fd19a374804af87ab24eac6b8a49
Patch Set 1 #
Messages
Total messages: 2 (1 generated)
|
|||||||||||||||||||