Do not show "Just a sec" page if arc-loading page is shown.

Do not show "Just a sec" page if arc-loading page is shown.

The "Just a sec" page looks redundant if we already show
"This may take up to a minute or so..." loading page,
from users' perspective.
Then, skip to show it.

BUG=670606
BUG=b/33163416
TEST=Ran bots.
TEST=Manually run opt-in flow.
     Accept ToS, and made sure no "Just a sec" page before "SIGN IN" page.
TEST=Manually run opt-in flow.
     Accept ToS. While "SIGN IN" is shown, log-out from ChromeOS account.
     Re-login. Then "Just a sec" is shown shortly just before "SIGN IN" page.
TEST=Manually run opt-in flow.
     Accept ToS. While "SIGN IN" is shown, disable network.
     Click "SIGN IN" and show error page. Re-establish the network.
     Click "TRY AGAIN" and made sure "Just a sec" is shown shortly just before
     "SIGN IN" page is re-shown.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/a1972e35f5d748015b9d9df96cfb3098c450bf36
Cr-Commit-Position: refs/heads/master@{#436155}

[hidehiko, 2016-12-02 09:28:04]

Description was changed from

==========
Do not show "Just a sec" page if arc-loading page is shown.

The "Just a sec" page looks redundant if we already show
"This may take up to a minute or so..." loading page,
from users' perspective.
Then, skip to show it.

BUG=670606
BUG=b/33163416
TEST=Ran bots.
TEST=Manually run opt-in flow.
     Accept ToS, and made sure no "Just a sec" page before "SIGN IN" page.
TEST=Manually run opt-in flow.
     Accept ToS. While "SIGN IN" is shown, log-out from ChromeOS account.
     Re-login. Then "Just a sec" is shown shortly just before "SIGN IN" page.
TEST=Manually run opt-in flow.
     Accept ToS. While "SIGN IN" is shown, disable network.
     Click "SIGN IN" and show error page. Re-establish the network.
     Click "TRY AGAIN" and made sure "Just a sec" is shown shortly just before
     "SIGN IN" page is re-shown.
==========

to

==========
Do not show "Just a sec" page if arc-loading page is shown.

The "Just a sec" page looks redundant if we already show
"This may take up to a minute or so..." loading page,
from users' perspective.
Then, skip to show it.

BUG=670606
BUG=b/33163416
TEST=Ran bots.
TEST=Manually run opt-in flow.
     Accept ToS, and made sure no "Just a sec" page before "SIGN IN" page.
TEST=Manually run opt-in flow.
     Accept ToS. While "SIGN IN" is shown, log-out from ChromeOS account.
     Re-login. Then "Just a sec" is shown shortly just before "SIGN IN" page.
TEST=Manually run opt-in flow.
     Accept ToS. While "SIGN IN" is shown, disable network.
     Click "SIGN IN" and show error page. Re-establish the network.
     Click "TRY AGAIN" and made sure "Just a sec" is shown shortly just before
     "SIGN IN" page is re-shown.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[hidehiko, 2016-12-02 09:28:47]

The CQ bit was checked by hidehiko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 09:29:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hidehiko, 2016-12-02 09:29:38]

hidehiko@chromium.org changed reviewers:
+ xiyuan@chromium.org

[hidehiko, 2016-12-02 09:29:39]

PTAL.

[commit-bot: I haz the power, 2016-12-02 10:26:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 10:26:09]

Dry run: This issue passed the CQ dry run.

[xiyuan, 2016-12-02 18:07:31]

lgtm

[hidehiko, 2016-12-03 02:54:27]

The CQ bit was checked by hidehiko@chromium.org

[commit-bot: I haz the power, 2016-12-03 02:54:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-03 03:17:00]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1480733667834570, "parent_rev":
"c6be16164db1c22233645d10bd60e4129e5586e0", "commit_rev":
"4f7fb6bdeb4d004048fe66d1ca4e6f4fc0a74129"}

[commit-bot: I haz the power, 2016-12-03 03:17:26]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-03 03:20:26]

Description was changed from

==========
Do not show "Just a sec" page if arc-loading page is shown.

The "Just a sec" page looks redundant if we already show
"This may take up to a minute or so..." loading page,
from users' perspective.
Then, skip to show it.

BUG=670606
BUG=b/33163416
TEST=Ran bots.
TEST=Manually run opt-in flow.
     Accept ToS, and made sure no "Just a sec" page before "SIGN IN" page.
TEST=Manually run opt-in flow.
     Accept ToS. While "SIGN IN" is shown, log-out from ChromeOS account.
     Re-login. Then "Just a sec" is shown shortly just before "SIGN IN" page.
TEST=Manually run opt-in flow.
     Accept ToS. While "SIGN IN" is shown, disable network.
     Click "SIGN IN" and show error page. Re-establish the network.
     Click "TRY AGAIN" and made sure "Just a sec" is shown shortly just before
     "SIGN IN" page is re-shown.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Do not show "Just a sec" page if arc-loading page is shown.

The "Just a sec" page looks redundant if we already show
"This may take up to a minute or so..." loading page,
from users' perspective.
Then, skip to show it.

BUG=670606
BUG=b/33163416
TEST=Ran bots.
TEST=Manually run opt-in flow.
     Accept ToS, and made sure no "Just a sec" page before "SIGN IN" page.
TEST=Manually run opt-in flow.
     Accept ToS. While "SIGN IN" is shown, log-out from ChromeOS account.
     Re-login. Then "Just a sec" is shown shortly just before "SIGN IN" page.
TEST=Manually run opt-in flow.
     Accept ToS. While "SIGN IN" is shown, disable network.
     Click "SIGN IN" and show error page. Re-establish the network.
     Click "TRY AGAIN" and made sure "Just a sec" is shown shortly just before
     "SIGN IN" page is re-shown.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/a1972e35f5d748015b9d9df96cfb3098c450bf36
Cr-Commit-Position: refs/heads/master@{#436155}
==========

[commit-bot: I haz the power, 2016-12-03 03:20:27]

Patchset 1 (id:??) landed as
https://crrev.com/a1972e35f5d748015b9d9df96cfb3098c450bf36
Cr-Commit-Position: refs/heads/master@{#436155}