Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 2552123007: Fix Data Saver settings preference crash on Lenovo Zuk devices (Closed)

Created:
4 years ago by megjablon
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Fix Data Saver settings preference crash on Lenovo Zuk devices The Data Saver settings menu is crashing for Lenovo Zuk devices due to findViewById returning null. Since we don't use the title in the PreferenceCategory, make the DataReductionStatsPreference a Preference and set the widget layout resource dynamically. Also, set the preference to not be selectable so that it does not have dividers and cannot be clicked. BUG=666412 Review-Url: https://codereview.chromium.org/2554723002 Cr-Commit-Position: refs/heads/master@{#436686} (cherry picked from commit c8b5b01012a5b4245eddb891c2557e7c6e3e64b6) Committed: https://chromium.googlesource.com/chromium/src/+/a4e3e0ff2a88903e6636bb3f782adb51060a1ebc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -9 lines) Patch
M chrome/android/java/res/xml/data_reduction_preferences.xml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionStatsPreference.java View 4 chunks +5 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
megjablon
4 years ago (2016-12-07 23:48:11 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a4e3e0ff2a88903e6636bb3f782adb51060a1ebc (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698